CacheCapabilities.max_batch_total_size_bytes refers to the size of the serialized protobuf messages, not the blobs #345
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e serialized protobuf messages, not the blobs I believe that this value was intended to help clients and servers avoid exceeding gRPC message length limits, which default to 4Mb in most configurations. When dealing with uncompressed blobs, the total size of the blobs is often approximately equal to the size of the serialized protobuf message. However this approximation is much less reliable when compressed blobs are involved in response messages (where the client doesn't know ahead of time how large the compressed blobs are). We should therefore describe this limit as referring to the size of the serialized requests/responses, and not of the approximation using the sizes of the blobs (either uncompressed or compressed). Resolves bazelbuild#344.
mostynb
commented
Sep 16, 2025
Comment on lines
+384
to
+386
| // * `RESOURCE_EXHAUSTED`: There is insufficient disk quota to store the blob, | ||
| // or if the size of the serialized BatchUpdateBlobsResponse message exceeds | ||
| // [CacheCapabilities.max_batch_total_size_bytes][build.bazel.remote.execution.v2.CacheCapabilities.max_batch_total_size_bytes]. |
There was a problem hiding this comment.
I am unsure about this part- I need to check what gRPC implementations actually return in this case.
There was a problem hiding this comment.
we got something like code = ResourceExhausted desc = gRPC message exceeds maximum size 4194304: 4196713
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe that this value was intended to help clients and servers avoid exceeding gRPC message length limits, which default to 4Mb in most configurations.
When dealing with uncompressed blobs, the total size of the blobs is often approximately equal to the size of the serialized protobuf message. However this approximation is much less reliable when compressed blobs are involved in response messages (where the client doesn't know ahead of time how large the compressed blobs are).
We should therefore describe this limit as referring to the size of the serialized requests/responses, and not of the approximation using the sizes of the blobs (either uncompressed or compressed).
Resolves #344.