Skip to content

Commit 24e2aa7

Browse files
committed
Should not have been committed without review.
Revert "Fix js test and format capabilities" This reverts commit 0c3e186.
1 parent 0c3e186 commit 24e2aa7

File tree

7 files changed

+13
-17
lines changed

7 files changed

+13
-17
lines changed

kotlin/compiler/compiler.bzl

Lines changed: 3 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -12,27 +12,19 @@
1212
# See the License for the specific language governing permissions and
1313
# limitations under the License.
1414

15-
load("@com_github_jetbrains_kotlin//:artifacts.bzl", "KOTLINC_ARTIFACTS")
15+
load("@rules_java//java:defs.bzl", "java_import")
1616
load("//kotlin:js.bzl", "kt_js_import")
1717
load("//kotlin:jvm.bzl", "kt_jvm_import")
1818
load("//kotlin/internal:defs.bzl", _KT_COMPILER_REPO = "KT_COMPILER_REPO")
19+
load("@com_github_jetbrains_kotlin//:artifacts.bzl", "KOTLINC_ARTIFACTS")
1920

2021
def _import_artifacts(artifacts, rule_kind):
2122
_import_labels(artifacts.plugin, rule_kind)
2223
_import_labels(artifacts.runtime, rule_kind)
2324
_import_labels(artifacts.compile, rule_kind, neverlink = 1)
2425

2526
def _import_labels(labels, rule_kind, **rule_args):
26-
for (label, file) in labels.items():
27-
if not file.endswith(".jar"):
28-
native.filegroup(
29-
name = label,
30-
srcs = [
31-
"@%s//:%s" % (_KT_COMPILER_REPO, label),
32-
],
33-
)
34-
return
35-
27+
for label in labels:
3628
if "-sources" in label:
3729
continue
3830
args = dict(rule_args.items())

kotlin/internal/js/js.bzl

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -152,6 +152,10 @@ kt_js_import = rule(
152152
cfg = "exec",
153153
),
154154
},
155+
outputs = dict(
156+
js = "%{module_name}.js",
157+
js_map = "%{module_name}.js.map",
158+
),
155159
implementation = _kt_js_import_impl,
156160
provides = [_KtJsInfo],
157161
)

src/main/kotlin/io/bazel/kotlin/builder/toolchain/KotlinToolchain.kt

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@ import org.jetbrains.kotlin.preloading.ClassPreloadingUtils
2424
import org.jetbrains.kotlin.preloading.Preloader
2525
import java.io.File
2626
import java.io.PrintStream
27+
import java.lang.ClassLoader
2728
import java.lang.reflect.Method
2829
import java.nio.file.FileSystems
2930
import java.nio.file.Path
@@ -258,6 +259,6 @@ class KotlinToolchain private constructor(
258259
toolchain: KotlinToolchain,
259260
) : KotlinCliToolInvoker(
260261
toolchain.toolchainWithReflect(),
261-
"org.jetbrains.kotlin.cli.js.K2JsIrCompiler",
262+
"org.jetbrains.kotlin.cli.js.K2JSCompiler",
262263
)
263264
}

src/main/starlark/core/repositories/BUILD.kotlin_capabilities.bazel

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,11 +11,11 @@
1111
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
1212
# See the License for the specific language governing permissions and
1313
# limitations under the License.
14+
package(default_visibility = ["//visibility:public"])
15+
1416
load("@bazel_skylib//:bzl_library.bzl", "bzl_library")
1517
load(":artifacts.bzl", "KOTLINC_ARTIFACT_LIST")
1618

17-
package(default_visibility = ["//visibility:public"])
18-
1919
bzl_library(
2020
name = "capabilities",
2121
srcs = glob(["*.bzl"]),

src/main/starlark/core/repositories/kotlin/artifacts.bzl

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@ KOTLINC_ARTIFACTS = struct(
55
plugin = {},
66
runtime = {
77
"kotlin-stdlib-js": "lib/kotlin-stdlib-js.jar",
8-
"kotlin-stdlib-js-klib": "lib/kotlin-stdlib-js.klib",
98
"kotlin-stdlib-js-sources": "lib/kotlin-stdlib-js-sources.jar",
109
"kotlin-test-js": "lib/kotlin-test-js.jar",
1110
"kotlin-test-js-sources": "lib/kotlin-test-js-sources.jar",

src/test/kotlin/io/bazel/kotlin/builder/tasks/BUILD.bazel

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -103,7 +103,7 @@ kt_rules_test(
103103
name = "KotlinBuilderJsTest",
104104
srcs = ["js/KotlinBuilderJsTest.java"],
105105
data = [
106-
"//kotlin/compiler:kotlin-stdlib-js-klib",
106+
"//kotlin/compiler:kotlin-stdlib-js.js",
107107
],
108108
)
109109

src/test/kotlin/io/bazel/kotlin/builder/tasks/js/KotlinBuilderJsTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
public class KotlinBuilderJsTest {
1313
private static final KotlinJsTestBuilder builder = new KotlinJsTestBuilder();
1414

15-
private Dep stdLib = Dep.fromLabel("//kotlin/compiler:kotlin-stdlib-js-klib");
15+
private Dep stdLib = Dep.fromLabel("@com_github_jetbrains_kotlin//:lib/kotlin-stdlib-js.jar");
1616

1717
@Test
1818
public void testSimpleJsCompile() {

0 commit comments

Comments
 (0)