-
Notifications
You must be signed in to change notification settings - Fork 232
Create a new "bootstrap" toolchain and compile with 2.1.0 #1244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 31 commits
1d71c79
125ceb7
c66eed3
23ecc6d
e0f20d5
c712839
10b48d6
3b7bffd
3f80a00
1a70251
b036cf2
7a13ebc
e2c7fc0
2ea9a15
a4331ff
435e900
b643a76
52eaa8b
64f9ac3
a913f0e
5f09d1b
79b04ce
fb7c090
0b7da29
ae72932
b0b3abd
fbd257c
aca7ee1
ff12c2c
c40d2e5
51b753b
e78858a
42c2f78
9088ba7
cd7ca3e
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,2 +1,5 @@ | ||
common --incompatible_enable_android_toolchain_resolution | ||
common --android_platforms=//:arm64-v8a | ||
common --enable_workspace=true | ||
common --enable_bzlmod=false | ||
common --android_platforms=//:arm64-v8a | ||
common --toolchain_resolution_debug=.* |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -7,13 +7,10 @@ http_archive( | |
) | ||
|
||
load("@rules_kotlin//kotlin:repositories.bzl", "kotlin_repositories") | ||
load("@rules_kotlin//src/main/starlark/core/repositories:versions.bzl", "versions") | ||
|
||
kotlin_repositories() | ||
|
||
register_toolchains("//bzl:experimental_toolchain") | ||
|
||
load("@rules_kotlin//src/main/starlark/core/repositories:versions.bzl", "versions") | ||
|
||
http_archive( | ||
name = "bazel_skylib", | ||
sha256 = versions.SKYLIB_SHA, | ||
|
@@ -37,24 +34,17 @@ load("@rules_jvm_external//:defs.bzl", "maven_install") | |
|
||
maven_install( | ||
artifacts = [ | ||
"androidx.appcompat:appcompat:1.0.0", | ||
"junit:junit:4.12", | ||
"androidx.test.espresso:espresso-core:3.1.1", | ||
"org.hamcrest:hamcrest-library:1.3", | ||
"org.jetbrains.kotlinx:kotlinx-serialization-runtime:1.0-M1-1.4.0-rc", | ||
"com.google.dagger:dagger:2.45", | ||
"com.google.dagger:dagger-compiler:2.45", | ||
"com.google.dagger:dagger-producers:2.45", | ||
"com.google.auto.value:auto-value:1.6.5", | ||
"com.google.auto.value:auto-value-annotations:1.6.5", | ||
"org.robolectric:robolectric:4.7.3", | ||
], | ||
repositories = [ | ||
"https://maven.google.com", | ||
"https://repo1.maven.org/maven2", | ||
], | ||
) | ||
|
||
register_toolchains("//bzl:experimental_toolchain") | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why does this need to be registered here in the example app? Is this requirement moving forward? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Defining a toolchain and not registering it means it will never be chosen. App didn't compile without the toolchain -- complained about all sorts of things. |
||
|
||
http_archive( | ||
name = "rules_android", | ||
sha256 = versions.ANDROID.SHA, | ||
|
@@ -70,13 +60,3 @@ load( | |
android_sdk_repository( | ||
name = "androidsdk", | ||
) | ||
|
||
http_archive( | ||
name = "robolectric", | ||
strip_prefix = "robolectric-bazel-4.7.3", | ||
urls = ["https://github.com/robolectric/robolectric-bazel/archive/4.7.3.tar.gz"], | ||
) | ||
|
||
load("@robolectric//bazel:robolectric.bzl", "robolectric_repositories") | ||
|
||
robolectric_repositories() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are these not being synced anymore for some reason?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed the build-kotlin-with kotlin, so we don't use the released rules anymore.