Unable to completing-read CMake preset the second time

[laurynas-biveinis]

Expected behavior

projectile-configure-project, when run second time in a project, has some way (a prefix arg?) to select a (different) CMake preset again.

Actual behavior

Configure command: cmake . --preset <previously-selected-preset> prompt in minibuffer without completion for presets.

Steps to reproduce the problem

• Have a CMake project with at least two configure presets
• s-p C, select one of the presets
• s-p C again, wishing to select the other preset

Environment & Version information

CMake 3.20.4

Projectile version information

Projectile 2.4.0

With a workaround for #1673 applied:

(defun dotfiles--projectile--cmake-all-command-presets (command-type)
  "Get CMake user and system COMMAND-TYPE presets."
  (projectile-flatten
   (mapcar (lambda (filename)
             (projectile--cmake-command-presets filename command-type))
           '("CMakeUserPresets.json" "CMakePresets.json"))))
(advice-add #'projectile--cmake-all-command-presets :override
            #'dotfiles--projectile--cmake-all-command-presets)

Emacs version

27.2

Operating system

macOS 11.4

[jehelset]

i think this is simply how the project-type-agnosticprojectile-configure-command works (https://github.com/bbatsov/projectile/blob/master/projectile.el#L4337). it will prefer to use the cached command. to get the behaviour you want, one would have to be able to disable caching of configuration commands. not sure if this is possible currently. it would be useful.

[jehelset]

as a quickfix you could use something like this:

(defun projectile-reconfigure-command (compile-dir)
  "Retrieve the configure command for COMPILE-DIR without considering history.

The command is determined like this:

- first we check for `projectile-project-configure-cmd' supplied
via .dir-locals.el

- finally we check for the default configure command for a
project of that type"
  (or projectile-project-configure-cmd
      (let ((cmd-format-string (projectile-default-configure-command (projectile-project-type))))
        (when cmd-format-string
          (format cmd-format-string (projectile-project-root) compile-dir)))))

(defun projectile-reconfigure-project (arg)
  "Run project configure command without considering command history.

Normally you'll be prompted for a compilation command, unless
variable `compilation-read-command'.  You can force the prompt
with a prefix ARG."
  (interactive "P")
  (let ((command (projectile-reconfigure-command (projectile-compilation-dir))))
    (projectile--run-project-cmd command projectile-configure-cmd-map
                                 :show-prompt arg
                                 :prompt-prefix "Configure command: "
                                 :save-buffers t)))

and bind projectile-reconfigure-command to a suitable key.

[laurynas-biveinis]

Thanks @jehelset , I will try your code. I really like the concept of separate "reconfigure" command.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contribution and understanding!

[laurynas-biveinis]

The issue still exists

[github-actions]

This issue has been automatically marked as stale because it has not had any recent activity. It will be closed soon if no further activity occurs. Thank you for your contribution and understanding!

[laurynas-biveinis]

The issue still exists

[jehelset]

if you set projectile-project-enable-cmd-caching to nil for your project it will not cache the configure command (or any other command) @laurynas-biveinis (#1768), i found that with presets this turns out quite ok.

do you still need a reconfigure command? if so i guess @bbatsov maybe can consider if it's an ok addition.

[laurynas-biveinis]

The workaround of resetting projectile-project-enable-cmd-caching to nil works, but makes experience worse for when I do want to use the previous preset, which is about half (?) of the time. IMHO a reconfigure command would still be a nice addition