DBC22-6337: return populated list and log errors when exception thrown

[bcgov-brwang]

📝 Submitter

🔗 JIRA Ticket

• **https://moti-imb.atlassian.net/browse/DBC22-6337

---

✅ Quality Assurance & Requirements

• Requirements Met: I have confirmed that all acceptance criteria from the JIRA ticket are fulfilled.
• Tested desktop in local or dev envs
• Tested mobile in local or dev envs
• Ran unit tests locally
• SonarCloud: I have verified that the SonarCloud analysis is clean/passing for this branch.

⚙️ Configuration & Environment

• New Env Variables: Does this PR require new environment variables? (Yes/No)

  If yes, please list them here and ensure they are added to secret manager, the .env.example. and the Vault by an STA.

🧪 How to Test (if required)

1. Go to tasks pod, execute command: . /vault/secrets/secrets.env && python manage.py populate_hef
2. Verify no errors reported

---

🔍 Reviewer Checklist

• Reviewed code for logic and cleanliness
• Re-tested desktop/mobile in local or dev envs
• Verified no new console warnings/errors
• Confirmed that any new env variables are understood/documented

[wmuldergov]

Question, so if the source API is returning an error, it will now presume a []. The problem with that is that I assume all HEF entries will be removed correct? If that is the case, we don't actually want that behavior. If source API is unable, just log an error but do not assume [].

[bcgov-brwang]

Question, so if the source API is returning an error, it will now presume a []. The problem with that is that I assume all HEF entries will be removed correct? If that is the case, we don't actually want that behavior. If source API is unable, just log an error but do not assume [].

Right, returning an empty list should not be a proper way to handle this, I've updated the code to return the json object populated, just log the error happend.

[wmuldergov]

Can you revert the test back to testing what happens in case of an API failure.
Also can you fix the sonarcloud failures?

[bcgov-brwang]

Can you revert the test back to testing what happens in case of an API failure. Also can you fix the sonarcloud failures?

Done

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud