fix: too few max replicas

This should lower the amount of email alert noise

Author: trev-dev

.github/workflows/deploy-to.openshift-dev.yml

@@ -34,7 +34,7 @@ env:
   COMMON_NAMESPACE: ${{ secrets.COMMON_NAMESPACE_NO_ENV }}
   TAG: "latest"
   MIN_REPLICAS_DEV: "1"
-  MAX_REPLICAS_DEV: "1"
+  MAX_REPLICAS_DEV: "2"
   MIN_CPU: "15m"
   MAX_CPU: "300m"
   MIN_MEM: "650Mi"
@@ -167,4 +167,4 @@ jobs:
       - name: ZAP Scan
         uses: zaproxy/action-api-scan@v0.2.0
         with:
-          target: 'https://${{ env.APP_NAME }}-${{ env.OPENSHIFT_NAMESPACE_DEV }}.apps.silver.devops.gov.bc.ca/v3/api-docs'
+          target: 'https://${{ env.APP_NAME }}-${{ env.OPENSHIFT_NAMESPACE_DEV }}.apps.silver.devops.gov.bc.ca/v3/api-docs'

.github/workflows/deploy-to.openshift-prod.yml

@@ -30,7 +30,7 @@ env:
   TAG: "latest"
   TARGET_ENV: "prod"
   MIN_REPLICAS: "3"
-  MAX_REPLICAS: "3"
+  MAX_REPLICAS: "4"
   MIN_CPU: "25m"
   MAX_CPU: "300m"
   MIN_MEM: "650Mi"
@@ -128,4 +128,4 @@ jobs:
           || true && echo "Rollout in progress"
           oc logs -f dc/${{ env.SPRING_BOOT_IMAGE_NAME }}
           # Get status, returns 0 if rollout is successful
-          oc rollout status dc/${{ env.SPRING_BOOT_IMAGE_NAME }}
+          oc rollout status dc/${{ env.SPRING_BOOT_IMAGE_NAME }}

.github/workflows/deploy-to.openshift-test.yml

@@ -34,7 +34,7 @@ env:
   COMMON_NAMESPACE: ${{ secrets.COMMON_NAMESPACE_NO_ENV }}
   TAG: ${{ github.event.inputs.tag }}
   MIN_REPLICAS_TEST: "2"
-  MAX_REPLICAS_TEST: "2"
+  MAX_REPLICAS_TEST: "3"
   MIN_CPU: "25m"
   MAX_CPU: "150m"
   MIN_MEM: "650Mi"
@@ -135,4 +135,4 @@ jobs:
       - name: ZAP Scan
         uses: zaproxy/action-api-scan@v0.2.0
         with:
-          target: 'https://${{ env.APP_NAME }}-${{ env.OPENSHIFT_NAMESPACE_TEST }}.apps.silver.devops.gov.bc.ca/v3/api-docs'
+          target: 'https://${{ env.APP_NAME }}-${{ env.OPENSHIFT_NAMESPACE_TEST }}.apps.silver.devops.gov.bc.ca/v3/api-docs'