From bb0c947e9872379c2764612d3b196086c34fa80f Mon Sep 17 00:00:00 2001
From: Khaled Smaoui <khaled.smaoui@gov.bc.ca>
Date: Mon, 23 Sep 2024 16:13:50 -0700
Subject: [PATCH 1/2] Added a parameter to disable the alert banner from
 showing when page hasn't loaded

---
 .../sdcCollection/sdcSchoolCollection/StepSevenSubmitData.vue | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/frontend/src/components/sdcCollection/sdcSchoolCollection/StepSevenSubmitData.vue b/frontend/src/components/sdcCollection/sdcSchoolCollection/StepSevenSubmitData.vue
index 9ac974f50..2d0f28cb5 100644
--- a/frontend/src/components/sdcCollection/sdcSchoolCollection/StepSevenSubmitData.vue
+++ b/frontend/src/components/sdcCollection/sdcSchoolCollection/StepSevenSubmitData.vue
@@ -67,7 +67,7 @@
       />
     </div>
     <v-alert
-      v-if="!isSubmitted"
+      v-if="!isSubmitted && hasLoaded"
       id="fte-info"
       density="compact"
       type="info"
@@ -141,6 +141,7 @@ export default {
       school: {},
       isSubmitted: false,
       isLoading: true,
+      hasLoaded: false,
       submittedStatuses: ['SUBMITTED', 'P_DUP_POST', 'P_DUP_VRFD', 'COMPLETED'],
       afterSubmittedStatuses: ['P_DUP_POST', 'P_DUP_VRFD', 'COMPLETED'],
     };
@@ -160,6 +161,7 @@ export default {
     sdcCollectionStore().getSchoolCollection(this.$route.params.schoolCollectionID).finally(() => {
       this.isSubmitted = this.submittedStatuses.includes(this.schoolCollection.sdcSchoolCollectionStatusCode);
       this.isLoading = !this.isLoading;
+      this.hasLoaded = true;
     });
   },
   created() {

From 915be8f4b096f33472865f926c5e32bf20edb6bd Mon Sep 17 00:00:00 2001
From: Khaled Smaoui <khaled.smaoui@gov.bc.ca>
Date: Mon, 23 Sep 2024 16:52:55 -0700
Subject: [PATCH 2/2] Use existing boolean instead

---
 .../sdcSchoolCollection/StepSevenSubmitData.vue              | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/frontend/src/components/sdcCollection/sdcSchoolCollection/StepSevenSubmitData.vue b/frontend/src/components/sdcCollection/sdcSchoolCollection/StepSevenSubmitData.vue
index 2d0f28cb5..cd03d4174 100644
--- a/frontend/src/components/sdcCollection/sdcSchoolCollection/StepSevenSubmitData.vue
+++ b/frontend/src/components/sdcCollection/sdcSchoolCollection/StepSevenSubmitData.vue
@@ -67,7 +67,7 @@
       />
     </div>
     <v-alert
-      v-if="!isSubmitted && hasLoaded"
+      v-if="!isSubmitted && !isLoading"
       id="fte-info"
       density="compact"
       type="info"
@@ -141,7 +141,6 @@ export default {
       school: {},
       isSubmitted: false,
       isLoading: true,
-      hasLoaded: false,
       submittedStatuses: ['SUBMITTED', 'P_DUP_POST', 'P_DUP_VRFD', 'COMPLETED'],
       afterSubmittedStatuses: ['P_DUP_POST', 'P_DUP_VRFD', 'COMPLETED'],
     };
@@ -161,7 +160,7 @@ export default {
     sdcCollectionStore().getSchoolCollection(this.$route.params.schoolCollectionID).finally(() => {
       this.isSubmitted = this.submittedStatuses.includes(this.schoolCollection.sdcSchoolCollectionStatusCode);
       this.isLoading = !this.isLoading;
-      this.hasLoaded = true;
+
     });
   },
   created() {