From 5c19df1afaa138d4c7cb6dd190b193b4b2edaa56 Mon Sep 17 00:00:00 2001 From: mightycox Date: Wed, 25 Sep 2024 16:24:14 -0700 Subject: [PATCH] EDX-2950 - stops deleted students from showing and fixes missing data in table on differences tab and --- backend/src/components/sdc.js | 5 +++++ .../stepThreeVerifyData/StudentDifferencesComponent.vue | 1 + 2 files changed, 6 insertions(+) diff --git a/backend/src/components/sdc.js b/backend/src/components/sdc.js index b12fa8059..81790c3a2 100644 --- a/backend/src/components/sdc.js +++ b/backend/src/components/sdc.js @@ -809,6 +809,11 @@ async function getStudentDifferencesByInstituteCollectionId(req, res) { const token = getAccessToken(req); let data = await getDataWithParams(token, `${config.get('sdc:rootURL')}/reportGeneration/differences`, params, req.session?.correlationID); + data = data?.map(pair => ({ + currentStudent: toTableRow(pair.currentStudent), + originalStudent: toTableRow(pair.originalStudent) + })); + data.forEach(difference => { difference.currentStudent.schoolName = getSchoolName(cacheService.getSchoolBySchoolID(difference.currentStudent.schoolID)); difference.originalStudent.type = 'Original'; diff --git a/frontend/src/components/sdcCollection/sdcDistrictCollection/stepThreeVerifyData/StudentDifferencesComponent.vue b/frontend/src/components/sdcCollection/sdcDistrictCollection/stepThreeVerifyData/StudentDifferencesComponent.vue index 1d218fc55..93b09afc4 100644 --- a/frontend/src/components/sdcCollection/sdcDistrictCollection/stepThreeVerifyData/StudentDifferencesComponent.vue +++ b/frontend/src/components/sdcCollection/sdcDistrictCollection/stepThreeVerifyData/StudentDifferencesComponent.vue @@ -153,6 +153,7 @@ export default defineComponent({ pageNumber: 1, filterSearchParams: { tabFilter: null, + notSdcSchoolCollectionStudentStatusCode: 'DELETED', moreFilters: {} }, headers: this.tableConfig.tableHeaders,