Skip to content

Commit 4cbba14

Browse files
authored
Merge pull request #542 from bcgov/feature/GRAD2-3037
Feature/grad2 3037
2 parents 6ced9be + 759a7d3 commit 4cbba14

File tree

4 files changed

+2
-10
lines changed

4 files changed

+2
-10
lines changed

api/src/main/java/ca/bc/gov/educ/api/batchgraduation/util/EducGradBatchGraduationApiConstants.java

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -277,9 +277,6 @@ public class EducGradBatchGraduationApiConstants {
277277
@Value("${endpoint.grad-student-api.read-grad-student-record-batch}")
278278
private String readGradStudentRecordBatch;
279279

280-
@Value("${endpoint.grad-graduation-report-api.get-school-report-list.url}")
281-
private String schoolReportPostingList;
282-
283280
@Value("${endpoint.grad-graduation-report-api.update-school-report.url}")
284281
private String updateSchoolReport;
285282

api/src/main/resources/application.yaml

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -225,15 +225,13 @@ endpoint:
225225
get-certificate-types:
226226
url: ${GRAD_GRADUATION_REPORT_API}api/v1/graduationreports/certificatetype/%s
227227
get-school-reports-lite-by-report-type:
228-
url: ${GRAD_GRADUATION_REPORT_API}api/v1/graduationreports/schoolreport/type/%s
228+
url: ${GRAD_GRADUATION_REPORT_API}api/v2/graduationreports/schoolreport/search?reportTypeCode=%s&isLight=true
229229
update-school-report:
230230
url: ${GRAD_GRADUATION_REPORT_API}api/v1/graduationreports/updateschoolreport?mincode=%s&reportTypeCode=%s
231231
update-student-report:
232232
url: ${GRAD_GRADUATION_REPORT_API}api/v1/graduationreports/studentreports?reportTypeCode=%s
233233
delete-student-report:
234234
url: ${GRAD_GRADUATION_REPORT_API}api/v1/graduationreports/delete?batchId=%s&reportType=%s
235-
get-school-report-list:
236-
url: ${GRAD_GRADUATION_REPORT_API}api/v1/graduationreports/schoolreportdistribution
237235
check-sccp-certificate-exists: ${GRAD_GRADUATION_REPORT_API}api/v1/graduationreports/check-sccp-certificate-exists
238236
grad-distribution-api:
239237
merge-n-upload:

api/src/test/java/ca/bc/gov/educ/api/batchgraduation/util/RestUtilsTest.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -791,7 +791,6 @@ public void testGetSchoolReportsLiteByReportType() {
791791
schoolReportsLite.add(sr);
792792

793793
mockTokenResponseObject();
794-
795794
when(this.restService.get(String.format(constants.getSchoolReportsLiteByReportTypeUrl(), "GRADREG"), List.class)).thenReturn(schoolReportsLite);
796795
when(LOGGER.isDebugEnabled()).thenReturn(true);
797796

api/src/test/resources/application.yaml

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -190,15 +190,13 @@ endpoint:
190190
get-certificate-types:
191191
url: https://educ-grad-graduation-report-api-77c02f-dev.apps.silver.devops.gov.bc.ca/api/v1/graduationreports/certificatetype/%s
192192
get-school-reports-lite-by-report-type:
193-
url: https://educ-grad-graduation-report-api-77c02f-dev.apps.silver.devops.gov.bc.ca/api/v1/graduationreports/schoolreport/type/%s
193+
url: https://educ-grad-graduation-report-api-77c02f-dev.apps.silver.devops.gov.bc.ca/api/v1/graduationreports/schoolreport/search?reportTypeCode=%s&isLight=true
194194
update-school-report:
195195
url: https://educ-grad-graduation-report-api-77c02f-dev.apps.silver.devops.gov.bc.ca/api/v1/graduationreports/updateschoolreports?mincode=%s&reportTypeCode=%s
196196
update-student-report:
197197
url: https://educ-grad-graduation-report-api-77c02f-dev.apps.silver.devops.gov.bc.ca/api/v1/graduationreports/studentreports?reportTypeCode=%s
198198
delete-student-report:
199199
url: https://educ-grad-graduation-report-api-77c02f-dev.apps.silver.devops.gov.bc.ca/api/v1/graduationreports/delete?batchId=%s&reportType=%s
200-
get-school-report-list:
201-
url: https://educ-grad-graduation-report-api-77c02f-dev.apps.silver.devops.gov.bc.ca/api/v1/graduationreports/schoolreportdistributionrun
202200
check-sccp-certificate-exists: https://educ-grad-graduation-report-api-77c02f-dev.apps.silver.devops.gov.bc.ca/api/v1/graduationreports/check-sccp-certificate-exists
203201
grad-distribution-api:
204202
merge-n-upload:

0 commit comments

Comments
 (0)