Fix for grades offered.

arcshiftsolutions · arcshiftsolutions · commit 1e40d92e9f19 · 2024-08-20T13:07:30.000-07:00
diff --git a/api/src/main/java/ca/bc/gov/educ/studentdatacollection/api/util/TransformUtil.java b/api/src/main/java/ca/bc/gov/educ/studentdatacollection/api/util/TransformUtil.java
@@ -118,7 +118,11 @@ public static String getGradesOfferedString(School school){
         gradesOffered.append(optGrade.get().getCode() + ",");
       }
     }
-    return gradesOffered.toString().substring(0,gradesOffered.lastIndexOf(","));
+    var finalGrades = gradesOffered.toString();
+    if(StringUtils.isEmpty(finalGrades)){
+      return "";
+    }
+    return gradesOffered.toString().substring(0, gradesOffered.lastIndexOf(","));
   }
 
   public static String sanitizeEnrolledProgramString(String enrolledProgramCode) {

Original file line number	Diff line number	Diff line change
`@@ -118,7 +118,11 @@ public static String getGradesOfferedString(School school){`
`118`	`118`	`gradesOffered.append(optGrade.get().getCode() + ",");`
`119`	`119`	`}`
`120`	`120`	`}`
`121`		`- return gradesOffered.toString().substring(0,gradesOffered.lastIndexOf(","));`
	`121`	`+ var finalGrades = gradesOffered.toString();`
	`122`	`+ if(StringUtils.isEmpty(finalGrades)){`
	`123`	`+ return "";`
	`124`	`+ }`
	`125`	`+ return gradesOffered.toString().substring(0, gradesOffered.lastIndexOf(","));`
`122`	`126`	`}`
`123`	`127`
`124`	`128`	`public static String sanitizeEnrolledProgramString(String enrolledProgramCode) {`