Merge pull request #1641 from bcgov/fix/summerRulesV04Dependent

summer rules dependent on v04

Author: arcshiftsolutions

api/src/main/java/ca/bc/gov/educ/studentdatacollection/api/constants/v1/ValidationRulesDependencyMatrix.java

@@ -62,14 +62,14 @@ public enum ValidationRulesDependencyMatrix {
     ENTRY54("V78", new String[]{DOB_INVALID_FORMAT.getCode(), ENROLLED_CODE_PARSE_ERR.getCode(), ENROLLED_CODE_INVALID.getCode()}),
     ENTRY55("V79", new String[]{DOB_INVALID_FORMAT.getCode(), SPED_ERR.getCode()}),
     ENTRY56("V90", new String[]{FUNDING_CODE_INVALID.getCode(), ENROLLED_CODE_PARSE_ERR.getCode(), ENROLLED_CODE_INVALID.getCode()}),
-    ENTRY57("V93", new String[]{SUMMER_PUBLIC_SCHOOL_GRADE_ERROR.getCode()}),
-    ENTRY58("V99", new String[]{SUMMER_PUBLIC_SCHOOL_GRADE_ERROR.getCode()}),
+    ENTRY57("V93", new String[]{DOB_INVALID_FORMAT.getCode(), SUMMER_PUBLIC_SCHOOL_GRADE_ERROR.getCode()}),
+    ENTRY58("V99", new String[]{DOB_INVALID_FORMAT.getCode(), SUMMER_PUBLIC_SCHOOL_GRADE_ERROR.getCode()}),
     ENTRY59("V94", new String[]{DOB_INVALID_FORMAT.getCode()}),
     ENTRY60("V92", new String[]{INVALID_GRADE_CODE.getCode()}),
     ENTRY61("V98", new String[]{DOB_INVALID_FORMAT.getCode()}),
     ENTRY62("V100", new String[]{ENROLLED_CODE_PARSE_ERR.getCode()}),
-    ENTRY63("V102", new String[]{SUMMER_PUBLIC_SCHOOL_GRADE_ERROR.getCode(), SUMMER_STUDENT_REPORTED_NOT_IN_DISTRICT_ERROR.getCode()}),
-    ENTRY64("V103", new String[]{SUMMER_PUBLIC_SCHOOL_GRADE_ERROR.getCode()}),
+    ENTRY63("V102", new String[]{DOB_INVALID_FORMAT.getCode(), SUMMER_PUBLIC_SCHOOL_GRADE_ERROR.getCode(), SUMMER_STUDENT_REPORTED_NOT_IN_DISTRICT_ERROR.getCode()}),
+    ENTRY64("V103", new String[]{DOB_INVALID_FORMAT.getCode(), SUMMER_PUBLIC_SCHOOL_GRADE_ERROR.getCode()}),
     ;
 
     @Getter

api/src/main/java/ca/bc/gov/educ/studentdatacollection/api/rules/validationrules/impl/SummerStudentOnlineLearningRule.java

@@ -24,7 +24,7 @@
 /**
  * | ID   | Severity | Rule                                                          | Dependent On |
  * |------|----------|-------------------------------------------------------------- |--------------|
- * | V102 | WARNING  | The student is not reported in the Online School in July and  | V92 , V99    |
+ * | V102 | WARNING  | The student is not reported in the Online School in July and  | V04, V92 , V99    |
  *                     was not reported in the online school in any previous
  *                     collections this school year
  *

api/src/main/java/ca/bc/gov/educ/studentdatacollection/api/rules/validationrules/impl/SummerStudentReportedInAuthorityRule.java

@@ -25,7 +25,7 @@
 /**
  * | ID   | Severity | Rule                                                          | Dependent On |
  * |----- |----------|-------------------------------------------------------------- |--------------|
- * | V103 | ERROR    | Student included in any collection in this school year        | V92          |
+ * | V103 | ERROR    | Student included in any collection in this school year        | V04, V92          |
  *                     for the authority with FTE > 0 in any school with type
  *                     different from online
  *                     OR if the student reported in Online school in the authority

api/src/main/java/ca/bc/gov/educ/studentdatacollection/api/rules/validationrules/impl/SummerStudentReportedInDistrictRule.java

@@ -25,7 +25,7 @@
 /**
  * | ID  | Severity | Rule                                                          | Dependent On |
  * |-----|----------|-------------------------------------------------------------- |--------------|
- * | V93 | ERROR    | Student included in any collection in this school year        | V92          |
+ * | V93 | ERROR    | Student included in any collection in this school year        | V04, V92     |
  *                    for the district with FTE > 0 in any school with type
  *                   different from online
  *                   OR if the student reported in Online school in the district

api/src/main/java/ca/bc/gov/educ/studentdatacollection/api/rules/validationrules/impl/SummerStudentReportedInOtherDistrictRule.java

@@ -20,7 +20,7 @@
 /**
  *  | ID  | Severity | Rule                                                          | Dependent On |
  *  |-----|----------|-------------------------------------------------------------- |--------------|
- *  | V99 | WARNING    | Student must be reported in Grade 8 or 9                   |V92           |
+ *  | V99 | WARNING    | Student must be reported in Grade 8 or 9                    | V04, V92           |
  *                     with FTE>0 in any other districts in previous
  *                     collection this school year to receive funding.
  */