Merge pull request #892 from bcgov/feature/registration-validation

Logging

Author: KFloodBCGov

server/StrDss.Service/PermitValidationService.cs

@@ -53,7 +53,8 @@ public PermitValidationService(IRegistrationApiClient regApiClient, IGeocoderApi
 
         try
         {
-            Response resp = await _regApiClient.ValidatePermitAsync(body, _apiAccount);
+            _logger.LogInformation("Calling validate permit.");
+           Response resp = await _regApiClient.ValidatePermitAsync(body, _apiAccount);
 
             // If we didn't get a Status field back, then there was an error
             if (string.IsNullOrEmpty(resp.Status))
@@ -65,28 +66,32 @@ public PermitValidationService(IRegistrationApiClient regApiClient, IGeocoderApi
                 }
                 else
                 {
-                   Dictionary<string, List<string>> errorDetails = resp.Errors
+                    _logger.LogInformation("Validate permit returned an error.");
+                    Dictionary<string, List<string>> errorDetails = resp.Errors
                         .GroupBy(e => e.Code)
                         .ToDictionary(g => g.Key, g => g.Select(e => e.Message).ToList());
                     registrationText = errorDetails.ParseError();
                 }
             }
             else if (!string.Equals(resp.Status, "ACTIVE", StringComparison.OrdinalIgnoreCase))
             {
+                _logger.LogInformation("Permit status is not ACTIVE.");
                 isValid = false;
                 registrationText = resp.Status;
 
             }
         }
         catch (ApiException ex)
         {
+            _logger.LogInformation("Validate permit call threw an Api exception: " + ex.Message);
             isValid = false;
             registrationText = ex.StatusCode == 404 ? RegistrationValidationText.ValidationException404 :
                 ex.StatusCode == 401 ? RegistrationValidationText.ValidationException401 :
                 RegistrationValidationText.ValidationException;
         }
         catch (Exception ex)
         {
+            _logger.LogInformation("Validate permit call threw an exception: " + ex.Message);
             isValid = false;
             registrationText = RegistrationValidationText.ValidationException;
         }

server/StrDss.Service/RegistrationService.cs

@@ -162,8 +162,10 @@ private async Task<bool> ProcessLine(DssUploadDelivery upload, DssUploadLine upl
             string registrationTxt = "";
             if (!string.IsNullOrEmpty(row.RegNo))
             {
+                _logger.LogInformation($"Processing: {row.RegNo} - {row.RentalUnit} - {row.RentalStreet} - {row.RentalPostal}");
                 // There is a reg no present, so we need to validate it
                 (isValid, registrationTxt) = await _permitValidation.ValidateRegistrationPermitAsync(row.RegNo, row.RentalUnit, row.RentalStreet, row.RentalPostal);
+                _logger.LogInformation("Validate permit response: " + registrationTxt);
                 if (isValid)
                 {
                     if (!string.IsNullOrEmpty(row.ListingId))