Skip to content

[SPDBT-4060] Schedule Job Error Handling improvements #2557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 7, 2025
Merged

[SPDBT-4060] Schedule Job Error Handling improvements #2557

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
52 changes: 35 additions & 17 deletions src/Spd.Manager.ScheduleJob/ScheduleJobManager.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,27 +73,45 @@ public async Task<Unit> Handle(RunScheduleJobSessionCommand cmd, CancellationTok
ScheduleJobSessionResp? resp = await _scheduleJobSessionRepository.GetAsync(cmd.JobSessionId, ct);
if (resp == null)
{
throw new ApiException(HttpStatusCode.BadRequest, "The schedule job session does not exist.");
string err = "The schedule job session does not exist.";
_logger.LogError(err);
throw new ApiException(HttpStatusCode.BadRequest, err);
}

Stopwatch stopwatch = Stopwatch.StartNew();
using var cts = new CancellationTokenSource(); // no timeout, this is the resolve for mysteriously cancelled requests
//request will from bcgov_schedulejob
//filterStr should be like "statecode eq 0 and spd_eligibleforcreditpayment eq 100000001"
RunJobRequest request = new RunJobRequest
try
{
PrimaryTypeName = resp.PrimaryEntity,
PrimaryEntityActionStr = resp.EndPoint,
PrimaryEntityName = resp.PrimaryEntity + "s",
PrimaryEntityFilterStr = resp.FilterStr.Trim(),
PrimaryEntityIdName = resp.PrimaryEntity + "id",
};
var result = await _generalizeScheduleJobRepository.RunJobsAsync(request, cmd.ConcurrentRequests, cts.Token);
stopwatch.Stop();
Stopwatch stopwatch = Stopwatch.StartNew();
using var cts = new CancellationTokenSource(); // no timeout, this is the resolve for mysteriously cancelled requests
//request will from bcgov_schedulejob
//filterStr should be like "statecode eq 0 and spd_eligibleforcreditpayment eq 100000001"
RunJobRequest request = new RunJobRequest
{
PrimaryTypeName = resp.PrimaryEntity,
PrimaryEntityActionStr = resp.EndPoint,
PrimaryEntityName = resp.PrimaryEntity + "s",
PrimaryEntityFilterStr = resp.FilterStr.Trim(),
PrimaryEntityIdName = resp.PrimaryEntity + "id",
};
var result = await _generalizeScheduleJobRepository.RunJobsAsync(request, cmd.ConcurrentRequests, cts.Token);
stopwatch.Stop();

//update result in JobSession
UpdateScheduleJobSessionCmd updateResultCmd = CreateUpdateScheduleJobSessionCmd(cmd.JobSessionId, result, Decimal.Round((decimal)(stopwatch.ElapsedMilliseconds / 1000), 2));
await _scheduleJobSessionRepository.ManageAsync(updateResultCmd, cts.Token);
//update result in JobSession
UpdateScheduleJobSessionCmd updateResultCmd = CreateUpdateScheduleJobSessionCmd(cmd.JobSessionId, result, Decimal.Round((decimal)(stopwatch.ElapsedMilliseconds / 1000), 2));
await _scheduleJobSessionRepository.ManageAsync(updateResultCmd, cts.Token);
}
catch (Exception ex)
{
string err = ex.Message;
if (ex.InnerException != null)
err += ex.InnerException.Message;
_logger.LogError(err);
UpdateScheduleJobSessionCmd updateCmd = new UpdateScheduleJobSessionCmd();
updateCmd.ScheduleJobSessionId = cmd.JobSessionId;
updateCmd.JobSessionStatusCode = JobSessionStatusCode.Failed;
updateCmd.ErrorMsg = err;
//update result in JobSession
await _scheduleJobSessionRepository.ManageAsync(updateCmd, ct);
}

return default;
}
Expand Down