Skip to content

chore: handle secrets without over exposure #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 19, 2025
Merged

chore: handle secrets without over exposure #63

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
569372d
chore: handle secrets without over exposure
DerekRoberts Feb 19, 2025
ab40704
Test
DerekRoberts Feb 19, 2025
c6b6a67
Test
DerekRoberts Feb 19, 2025
8401cbc
Test
DerekRoberts Feb 19, 2025
0e86631
Test formatting
DerekRoberts Feb 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ jobs:
include:
- name: backend
dir: backend
token: SONAR_TOKEN_BACKEND
triggers: ('backend/')
triggers_event: ('pull_request')
- name: frontend-merge
Expand All @@ -35,7 +34,6 @@ jobs:
triggers_event: ('pull_request')
- name: frontend-pr
dir: frontend
token: SONAR_TOKEN_FRONTEND
triggers_event: ('push')
steps:
- uses: actions/checkout@v4
Expand All @@ -54,6 +52,8 @@ jobs:
-Dsonar.projectKey=bcgov-nr_action-test-and-analyse_${{ matrix.dir }}
-Dsonar.sources=src
-Dsonar.tests.inclusions=**/*spec.ts
sonar_token: ${{ secrets[matrix.token] }}
sonar_token: ${{ matrix.name == 'backend' && secrets.SONAR_TOKEN_BACKEND
|| matrix.name == 'frontend-pr' && secrets.SONAR_TOKEN_FRONTEND
|| '' }}
triggers: ${{ matrix.triggers }}
triggers_event: ${{ matrix.triggers_event }}
Loading