match GatewayController activity in OrgController v3 #1171
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No idea why but this this change has led to a new test consistently failing:
|
rustyjux
force-pushed
the
feature/org-error
branch
from
f6d6a9d to
072abd1
Compare
|
Passed all tests (https://github.com/bcgov/api-services-portal/actions/runs/10820076785). So I think it was a flaky test thing. |
Elson9
approved these changes
Sep 12, 2024
rustyjux
added a commit
that referenced
this pull request
Sep 12, 2024
* scroll to top, fix redirect for gateway detail * add return null * scroll to top of details on nav from /list * Cypress/ns to gw cli tests (#1158) Cypress tests for new features in `gwa` CLI from NS to GW. * replace Namespace with Gateway in org permission (#1159) * Feature/ns to gw redirect (#1162) * fix some capitlization * fix no gw redirect handling and add toast * more details on login * show error for invalid display name format * reset edit display name input on cancel * avoid white bg on button hover if disabled * match GatewayController activity in OrgController v3 (#1171) * match GatewayController activity in OrgController v3 * openapi update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 Feature branch deployment: https://api-services-portal-feature-org-error.apps.silver.devops.gov.bc.ca