chore: updated test

Signed-off-by: Mac Deluca <Mac.Deluca@quartech.com>

Author: MacDeluca

app/__tests__/bcsc-theme/hooks/useQuickLoginURL.test.ts

@@ -1,18 +1,15 @@
-jest.mock('@bifold/core')
-jest.mock('@/bcsc-theme/api/hooks/useApi')
-jest.mock('@/bcsc-theme/hooks/useBCSCApiClient')
-jest.mock('@/bcsc-theme/hooks/useDataLoader', () => ({
-  __esModule: true,
-  default: jest.fn(),
-}))
-
 import * as useApi from '@/bcsc-theme/api/hooks/useApi'
 import * as useBCSCApiClient from '@/bcsc-theme/hooks/useBCSCApiClient'
 import useDataLoader from '@/bcsc-theme/hooks/useDataLoader'
 import { useQuickLoginURL } from '@/bcsc-theme/hooks/useQuickLoginUrl'
 import * as Bifold from '@bifold/core'
 import { renderHook, waitFor } from '@testing-library/react-native'
 
+jest.mock('@bifold/core')
+jest.mock('@/bcsc-theme/api/hooks/useApi')
+jest.mock('@/bcsc-theme/hooks/useBCSCApiClient')
+jest.mock('@/bcsc-theme/hooks/useDataLoader')
+
 describe('useQuickLoginURL', () => {
   beforeEach(() => {
     jest.resetAllMocks()
@@ -24,7 +21,7 @@ describe('useQuickLoginURL', () => {
     const bifoldMock = jest.mocked(Bifold)
     const useDataLoaderMock = jest.mocked(useDataLoader)
 
-    useApiMock.default.mockReturnValue({ jwks: jest.fn() } as any)
+    useApiMock.default.mockReturnValue({ jwks: { getFirstJwk: jest.fn() } } as any)
     useClientMock.useBCSCApiClient.mockReturnValue({} as any)
     bifoldMock.useServices.mockReturnValue([{ error: jest.fn() }] as any)
 
@@ -37,11 +34,12 @@ describe('useQuickLoginURL', () => {
       .mockReturnValueOnce(tokensLoaderMock)
       .mockReturnValueOnce(accountLoaderMock)
 
-    const hook = renderHook(() => useQuickLoginURL({ client_ref_id: '', initiate_login_uri: 'https://login' }))
+    const hook = renderHook(() => useQuickLoginURL({ client_ref_id: '' }))
 
     // Wait for useEffect to run
     await waitFor(() => {
       const [url, error] = hook.result.current
+
       expect(url).toBeNull()
       expect(error).toBeNull()
     })

app/src/bcsc-theme/features/services/ServiceLoginScreen.tsx

@@ -161,8 +161,9 @@ export const ServiceLoginScreen: React.FC<ServiceLoginScreenProps> = (props: Ser
                     return
                   }
 
-                  // This should never happen, but just in case...
-                  Alert.alert(t('Services.LoginErrorTitle'), quickLoginError ?? undefined)
+                  if (quickLoginError) {
+                    Alert.alert(t('Services.LoginErrorTitle'), quickLoginError)
+                  }
                 }}
               />
             </View>

app/src/bcsc-theme/hooks/useQuickLoginUrl.tsx

@@ -101,7 +101,7 @@ export const useQuickLoginURL = (serviceClient: ClientMetadataStub): QuickLoginU
         handleQuickLoginUpdate(`${serviceClient.initiate_login_uri}?login_hint=${encodedTokenHint}`, null)
       } catch (error) {
         logger.error('Error creating quick login URL', error as Error)
-        handleQuickLoginUpdate(null, `Error creating quick login URL ${(error as Error).message}`)
+        handleQuickLoginUpdate(null, `Error creating quick login URL: ${(error as Error).message}`)
       }
     }