fix: fixed notifications on home screen when returning from mob verifier #2145
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: wadeking98 <wkingnumber2@gmail.com>
bryce-mcmath
previously approved these changes
Aug 27, 2024
|
I'm assuming this won't hide proof requests that have been seen but not responded to. But I'm not sure how... |
Signed-off-by: wadeking98 <wkingnumber2@gmail.com>
|
|
@bryce-mcmath made a couple fixes and I'll need your review again |
bryce-mcmath
approved these changes
Aug 28, 2024
jleach
pushed a commit
that referenced
this pull request
Mar 13, 2025
…ier (#2145) Signed-off-by: wadeking98 <wkingnumber2@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously when exiting the mobile verifier page and returning to the home screen the notification state wouldn't update, This would mean that there were two notifications on the home page, one from the person credential, and one from the proof request that had already been viewed. Once you navigate away and then back to the home screen the erroneous notification would be removed, but the notification bubble on the tabstack would still say there's 2 notifications.
This change fixes the useNotifications hook so that the notifications hook is updated whenever the proof request is marked as seen. This ensures we don't get an erroneous proof notification on the home screen