Skip to content

fix: fixed notifications on home screen when returning from mob verifier #2145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 28, 2024
Merged

fix: fixed notifications on home screen when returning from mob verifier #2145

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8782650
fixed notifications on home screen when returning from mob verifier
wadeking98 Aug 27, 2024
1a88ca9
bug fixes for notification
wadeking98 Aug 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 7 additions & 10 deletions app/src/hooks/notifications.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,11 +67,14 @@ export const useNotifications = (): Array<BasicMessageRecord | CredentialRecord
const invitationDate = new Date()
const custom =
showPersonCredentialSelector(credentialDefinitionIDs) &&
!store.dismissPersonCredentialOffer.personCredentialOfferDismissed
!store.dismissPersonCredentialOffer.personCredentialOfferDismissed
? [{ type: 'CustomNotification', createdAt: invitationDate, id: 'custom' }]
: []

const notif = [...messagesToShow, ...offers, ...nonAttestationProofs, ...revoked].sort(
const proofs = nonAttestationProofs.filter((proof) => {
return ![ProofState.Done, ProofState.PresentationReceived].includes(proof.state) ||
(proof.isVerified !== undefined && !(proof.metadata.data[ProofMetadata.customMetadata] as ProofCustomMetadata)?.details_seen)
})
const notif = [...messagesToShow, ...offers, ...proofs, ...revoked].sort(
(a, b) => new Date(b.createdAt).getTime() - new Date(a.createdAt).getTime()
)

Expand All @@ -80,14 +83,8 @@ export const useNotifications = (): Array<BasicMessageRecord | CredentialRecord
}, [offers, credsReceived, credsDone, basicMessages, nonAttestationProofs])

useEffect(() => {
const validProofsDone = proofsDone.filter((proof: ProofExchangeRecord) => {
if (proof.isVerified === undefined) return false

const metadata = proof.metadata.get(ProofMetadata.customMetadata) as ProofCustomMetadata
return !metadata?.details_seen
})
Promise.all(
[...proofsRequested, ...validProofsDone].map(async (proof: ProofExchangeRecord) => {
[...proofsRequested, ...proofsDone].map(async (proof: ProofExchangeRecord) => {
const isAttestation = await isProofRequestingAttestation(proof, agent as BifoldAgent, AttestationRestrictions)
return {
value: proof,
Expand Down
Loading