Skip to content

chore: remove extra style prop array wrapping #2162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 13, 2024
Merged

chore: remove extra style prop array wrapping #2162

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
198 changes: 80 additions & 118 deletions app/__tests__/screens/__snapshots__/Developer.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,12 +35,10 @@ exports[`Developer Screen screen renders correctly 1`] = `
<View>
<View
style={
[
{
"backgroundColor": "#313132",
"padding": 24,
},
]
{
"backgroundColor": "#313132",
"padding": 24,
}
}
>
<View
Expand Down Expand Up @@ -130,11 +128,9 @@ exports[`Developer Screen screen renders correctly 1`] = `
</View>
<View
style={
[
{
"marginBottom": 10,
},
]
{
"marginBottom": 10,
}
}
/>
<View
Expand Down Expand Up @@ -195,12 +191,10 @@ exports[`Developer Screen screen renders correctly 1`] = `
</View>
<View
style={
[
{
"backgroundColor": "#313132",
"padding": 24,
},
]
{
"backgroundColor": "#313132",
"padding": 24,
}
}
>
<View
Expand Down Expand Up @@ -285,21 +279,17 @@ exports[`Developer Screen screen renders correctly 1`] = `
</View>
<View
style={
[
{
"marginBottom": 10,
},
]
{
"marginBottom": 10,
}
}
/>
<View
style={
[
{
"backgroundColor": "#313132",
"padding": 24,
},
]
{
"backgroundColor": "#313132",
"padding": 24,
}
}
>
<View
Expand Down Expand Up @@ -396,24 +386,20 @@ exports[`Developer Screen screen renders correctly 1`] = `
>
<View
style={
[
{
"borderBottomColor": "#000000",
"borderBottomWidth": 1,
"marginHorizontal": 24,
},
]
{
"borderBottomColor": "#000000",
"borderBottomWidth": 1,
"marginHorizontal": 24,
}
}
/>
</View>
<View
style={
[
{
"backgroundColor": "#313132",
"padding": 24,
},
]
{
"backgroundColor": "#313132",
"padding": 24,
}
}
>
<View
Expand Down Expand Up @@ -510,24 +496,20 @@ exports[`Developer Screen screen renders correctly 1`] = `
>
<View
style={
[
{
"borderBottomColor": "#000000",
"borderBottomWidth": 1,
"marginHorizontal": 24,
},
]
{
"borderBottomColor": "#000000",
"borderBottomWidth": 1,
"marginHorizontal": 24,
}
}
/>
</View>
<View
style={
[
{
"backgroundColor": "#313132",
"padding": 24,
},
]
{
"backgroundColor": "#313132",
"padding": 24,
}
}
>
<View
Expand Down Expand Up @@ -624,24 +606,20 @@ exports[`Developer Screen screen renders correctly 1`] = `
>
<View
style={
[
{
"borderBottomColor": "#000000",
"borderBottomWidth": 1,
"marginHorizontal": 24,
},
]
{
"borderBottomColor": "#000000",
"borderBottomWidth": 1,
"marginHorizontal": 24,
}
}
/>
</View>
<View
style={
[
{
"backgroundColor": "#313132",
"padding": 24,
},
]
{
"backgroundColor": "#313132",
"padding": 24,
}
}
>
<View
Expand Down Expand Up @@ -738,24 +716,20 @@ exports[`Developer Screen screen renders correctly 1`] = `
>
<View
style={
[
{
"borderBottomColor": "#000000",
"borderBottomWidth": 1,
"marginHorizontal": 24,
},
]
{
"borderBottomColor": "#000000",
"borderBottomWidth": 1,
"marginHorizontal": 24,
}
}
/>
</View>
<View
style={
[
{
"backgroundColor": "#313132",
"padding": 24,
},
]
{
"backgroundColor": "#313132",
"padding": 24,
}
}
>
<View
Expand Down Expand Up @@ -852,24 +826,20 @@ exports[`Developer Screen screen renders correctly 1`] = `
>
<View
style={
[
{
"borderBottomColor": "#000000",
"borderBottomWidth": 1,
"marginHorizontal": 24,
},
]
{
"borderBottomColor": "#000000",
"borderBottomWidth": 1,
"marginHorizontal": 24,
}
}
/>
</View>
<View
style={
[
{
"backgroundColor": "#313132",
"padding": 24,
},
]
{
"backgroundColor": "#313132",
"padding": 24,
}
}
>
<View
Expand Down Expand Up @@ -966,24 +936,20 @@ exports[`Developer Screen screen renders correctly 1`] = `
>
<View
style={
[
{
"borderBottomColor": "#000000",
"borderBottomWidth": 1,
"marginHorizontal": 24,
},
]
{
"borderBottomColor": "#000000",
"borderBottomWidth": 1,
"marginHorizontal": 24,
}
}
/>
</View>
<View
style={
[
{
"backgroundColor": "#313132",
"padding": 24,
},
]
{
"backgroundColor": "#313132",
"padding": 24,
}
}
>
<View
Expand Down Expand Up @@ -1074,12 +1040,10 @@ exports[`Developer Screen screen renders correctly 1`] = `
</View>
<View
style={
[
{
"backgroundColor": "#313132",
"padding": 24,
},
]
{
"backgroundColor": "#313132",
"padding": 24,
}
}
>
<View
Expand Down Expand Up @@ -1170,12 +1134,10 @@ exports[`Developer Screen screen renders correctly 1`] = `
</View>
<View
style={
[
{
"backgroundColor": "#313132",
"padding": 24,
},
]
{
"backgroundColor": "#313132",
"padding": 24,
}
}
>
<View
Expand Down
2 changes: 1 addition & 1 deletion app/src/components/LoadingIcon.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ export default function LoadingIcon({ size, color, active }: Readonly<LoadingIco

return (
<>
<Animated.View style={[{ transform: [{ rotate: rotation }] }]}>
<Animated.View style={{ transform: [{ rotate: rotation }] }}>
<Icon style={{ color }} size={size} name="refresh" />
</Animated.View>
</>
Expand Down
8 changes: 4 additions & 4 deletions app/src/screens/Developer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ const Settings: React.FC = () => {
subContent,
}: SectionRowProps) => (
<>
<View style={[styles.section]}>
<View style={styles.section}>
<View style={{ flexDirection: 'row' }}>
<Text style={styles.rowTitle}>{title}</Text>
<Pressable
Expand All @@ -128,7 +128,7 @@ const Settings: React.FC = () => {
</View>
{showRowSeparator && (
<View style={{ backgroundColor: SettingsTheme.groupBackground }}>
<View style={[styles.rowSeparator]}></View>
<View style={styles.rowSeparator}></View>
</View>
)}
</>
Expand Down Expand Up @@ -296,7 +296,7 @@ const Settings: React.FC = () => {
value={devMode}
/>
</SectionRow>
<View style={[styles.sectionSeparator]}></View>
<View style={styles.sectionSeparator}></View>
<SectionHeader icon={'apartment'} title={'IAS'} />
<SectionRow
title={t('Developer.Environment')}
Expand All @@ -310,7 +310,7 @@ const Settings: React.FC = () => {
{store.developer.environment.name}
</Text>
</SectionRow>
<View style={[styles.sectionSeparator]}></View>
<View style={styles.sectionSeparator}></View>
<SectionRow
title={t('Verifier.UseVerifierCapability')}
accessibilityLabel={t('Verifier.Toggle')}
Expand Down
6 changes: 3 additions & 3 deletions app/src/screens/IASEnvironment.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,14 +51,14 @@ const IASEnvironmentScreen: React.FC<IASEnvironmentProps> = ({ shouldDismissModa
}

return (
<SafeAreaView style={[styles.container]}>
<SafeAreaView style={styles.container}>
<FlatList
data={environments}
renderItem={({ item: environment }) => {
const { name }: IASEnvironment = environment
return (
<View style={[styles.section, styles.sectionRow]}>
<Text style={[TextTheme.title]}>{t(`Developer.${name}`)}</Text>
<Text style={TextTheme.title}>{t(`Developer.${name}`)}</Text>
<BouncyCheckbox
accessibilityLabel={name}
disableText
Expand All @@ -79,7 +79,7 @@ const IASEnvironmentScreen: React.FC<IASEnvironmentProps> = ({ shouldDismissModa
}}
ItemSeparatorComponent={() => (
<View style={{ backgroundColor: SettingsTheme.groupBackground }}>
<View style={[styles.itemSeparator]}></View>
<View style={styles.itemSeparator}></View>
</View>
)}
/>
Expand Down
Loading
Loading