Skip to content

Conversation

MacDeluca
Copy link
Contributor

@MacDeluca MacDeluca commented Sep 4, 2025

Summary of Changes

Allows users to register for BCSC without a BC Services card. Verification flow requires two non BCSC identification cards, alongside additional metadata that is required for IAS API calls.

The flow for this is slightly different, as a lot of the metadata is not auto-populated anymore. The user will need to manually enter their address, email and submit an additional ID.

Lots of the changes where related to the SetupStepsScreen and organizing the state logic there. Mostly making it compatible with non-bcsc card verifications.

New components:

  1. SetupStep - Unified the styling of the Steps in SetupStepsScreen into one component.
  2. ResidentialAddressScreen - For entering the users address information
  3. InputWithValidation - Stateless component which renders an input, label, error etc.
  4. DualIdentificationRequiredScreen - Information screen when registering non BCSC identification cards.

Screenshots, videos, or gifs

...

Related Issues

N/A

Pull Request Checklist

Tick all boxes below to demonstrate that you have completed the respective task. If the item does not apply to your this PR check it anyway to make it apparent that there's nothing to do.

  • All commits contain a DCO Signed-off-by line (we use the DCO GitHub app to enforce this)
  • Related issues are included under the Related Issues section above
  • If applicable, screenshots, gifs, or video are included for UI changes

@MacDeluca MacDeluca marked this pull request as draft September 4, 2025 19:28
Copilot

This comment was marked as outdated.

@MacDeluca MacDeluca marked this pull request as ready for review September 5, 2025 16:02
@MacDeluca MacDeluca requested a review from Copilot September 5, 2025 19:52
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements support for non-BCSC identification cards, allowing users to register using two alternative government-issued IDs instead of a BC Services Card. The implementation includes new verification flows, UI components, and state management for collecting additional user metadata.

  • Adds support for dual non-BCSC identification verification flow
  • Introduces residential address collection for non-BCSC users
  • Implements comprehensive step-by-step setup process with proper state management

Reviewed Changes

Copilot reviewed 23 out of 23 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
app/src/store.tsx Adds user metadata state management and dispatch actions for non-BCSC flows
app/src/localization/*/index.ts Adds translations for new UI elements across multiple languages
app/src/hooks/useSetupSteps.ts New hook for managing setup step completion and focus states
app/src/bcsc-theme/utils/get-province-code.ts Utility for validating and normalizing Canadian province codes
app/src/bcsc-theme/types/navigators.ts Adds new screen navigation types
app/src/bcsc-theme/types/cards.ts Updates card type enum for non-BCSC identification
app/src/bcsc-theme/features/verify/non-photo/EvidenceTypeListScreen.tsx Enhances evidence selection with better filtering and descriptions
app/src/bcsc-theme/features/verify/non-photo/EvidenceIDCollectionScreen.tsx Major refactor to support comprehensive form data collection
app/src/bcsc-theme/features/verify/non-photo/DualIdentificationRequiredScreen.tsx New information screen for dual ID requirements
app/src/bcsc-theme/features/verify/components/SetupStep.tsx Reusable component for setup step UI consistency
app/src/bcsc-theme/features/verify/SetupStepsScreen.tsx Complete refactor using new step management hook
app/src/bcsc-theme/features/verify/ResidentialAddressScreen.tsx New screen for address collection with validation
app/src/bcsc-theme/components/InputWithValidation.tsx Reusable input component with validation support
app/__tests__/hooks/useSetupSteps.test.tsx Comprehensive test coverage for the new step management logic

Copy link
Contributor

@al-rosenthal al-rosenthal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few things I've noticed so far:
Some safe areas need to be fixed.
thumb-1757363647843
"You must provide two government-issued IDs" screen

thumb-1757363647872
"Take a photo of your ID. An agent..." screen

Residential Address form:
thumb-1757363647891
It would be great if this was a dropdown/ picker. Or if that's a lot it would be great to have the example (AB, BC...) not obvious what it's expecting

I also get stuck at the residential address form:

  • the postal code doesn't accept valid postal codes (V8Z 1C8) I can only get A2A 2B2 to work
  • The endpoint is failing with a 400 "invalid_parameter"

Copy link
Contributor

@al-rosenthal al-rosenthal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the non photo bcsc flow, I'm unable to get passed the "You must provide additional ID because of your BC services..." isn't scrollable so I can't get to the button

(cherry picked from commit 362c242)
Signed-off-by: Mac Deluca <Mac.Deluca@quartech.com>
(cherry picked from commit 362c242)
Signed-off-by: Mac Deluca <Mac.Deluca@quartech.com>
@MacDeluca MacDeluca force-pushed the md_bcsc_2534_non_bcsc_id_verify branch from 5492d47 to c9adaf6 Compare September 9, 2025 16:44
Copy link

sonarqubecloud bot commented Sep 9, 2025

@MacDeluca MacDeluca closed this Sep 9, 2025
@MacDeluca MacDeluca deleted the md_bcsc_2534_non_bcsc_id_verify branch September 9, 2025 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants