Skip to content

Conversation

MacDeluca
Copy link
Contributor

@MacDeluca MacDeluca commented Sep 15, 2025

Summary of Changes

This PR re-introduces the Service catalogue in the single app (BCSC). It also includes a new searching functionality that did not exist previously. The list now fetches from IAS and filters based on the users card type (ie: BCSCCardProcess)

  • Re-factored the useQuickLoginURL to accept a serviceClient(ClientMetadata) object, for reusability.
  • Added a new hook useFilterServiceClients - it fetches and filters the service clients based on a config.
  • Added a new hook useDebounce - used to delay the filtering of the serviceClients till after the user has stopped typing
  • New screen ServiceLoginScreen - either provides information of the service or allows quick login

Testing Notes

  • There are two types of services:
  1. Services which allow quick login
  2. Services which do not
  • Filter the list for BC Services Card, the first one allows quick login, the second does not.

Screenshots, videos, or gifs

IMG_0074 IMG_0075 IMG_0073 IMG_0076

Related Issues

#2563

Pull Request Checklist

Tick all boxes below to demonstrate that you have completed the respective task. If the item does not apply to your this PR check it anyway to make it apparent that there's nothing to do.

  • All commits contain a DCO Signed-off-by line (we use the DCO GitHub app to enforce this)
  • Related issues are included under the Related Issues section above
  • If applicable, screenshots, gifs, or video are included for UI changes

Signed-off-by: Mac Deluca <Mac.Deluca@quartech.com>
Signed-off-by: Mac Deluca <Mac.Deluca@quartech.com>
Signed-off-by: Mac Deluca <Mac.Deluca@quartech.com>
Signed-off-by: Mac Deluca <Mac.Deluca@quartech.com>
Signed-off-by: Mac Deluca <Mac.Deluca@quartech.com>
Signed-off-by: Mac Deluca <Mac.Deluca@quartech.com>
Signed-off-by: Mac Deluca <Mac.Deluca@quartech.com>
Signed-off-by: Mac Deluca <Mac.Deluca@quartech.com>
Signed-off-by: Mac Deluca <Mac.Deluca@quartech.com>
Signed-off-by: Mac Deluca <Mac.Deluca@quartech.com>
Signed-off-by: Mac Deluca <Mac.Deluca@quartech.com>
Signed-off-by: Mac Deluca <Mac.Deluca@quartech.com>
Signed-off-by: Mac Deluca <Mac.Deluca@quartech.com>
Signed-off-by: Mac Deluca <Mac.Deluca@quartech.com>
Signed-off-by: Mac Deluca <Mac.Deluca@quartech.com>
Signed-off-by: Mac Deluca <Mac.Deluca@quartech.com>
Signed-off-by: Mac Deluca <Mac.Deluca@quartech.com>
Signed-off-by: Mac Deluca <Mac.Deluca@quartech.com>
Signed-off-by: Mac Deluca <Mac.Deluca@quartech.com>
Signed-off-by: Mac Deluca <Mac.Deluca@quartech.com>
Signed-off-by: Mac Deluca <Mac.Deluca@quartech.com>
Signed-off-by: Mac Deluca <Mac.Deluca@quartech.com>
Signed-off-by: Mac Deluca <Mac.Deluca@quartech.com>
Signed-off-by: Mac Deluca <Mac.Deluca@quartech.com>
Signed-off-by: Mac Deluca <Mac.Deluca@quartech.com>
Signed-off-by: Mac Deluca <Mac.Deluca@quartech.com>
Signed-off-by: Mac Deluca <Mac.Deluca@quartech.com>
Signed-off-by: Mac Deluca <Mac.Deluca@quartech.com>
@MacDeluca MacDeluca changed the title feat: service catalogue (issue #2563) feat: BCSC service catalogue (issue #2563) Sep 15, 2025
Signed-off-by: Mac Deluca <Mac.Deluca@quartech.com>
Signed-off-by: Mac Deluca <Mac.Deluca@quartech.com>
bryce-mcmath
bryce-mcmath previously approved these changes Sep 16, 2025
Copy link
Contributor

@bryce-mcmath bryce-mcmath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pr rocks 🎸

},
})

// TODO (MD): implement a loading UI
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not for this PR but maybe in a future improvement; I think just a centered <ActivityIndicator size={'large'} /> is good enough in most cases and is similar to the current BCSC's loading mechanics

@MacDeluca
Copy link
Contributor Author

@bryce-mcmath Thanks for the review :) I'm just filling in some missing tests, I can ping you when I have all my changes in.

Copy link
Contributor

@al-rosenthal al-rosenthal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I saw some oddities while testing this locally on my android device:
this might just be a test date issue but the privacy notice didn't link anywhere
dummy

After verification and navigating to the BC Services Card with the login, this is what I see when I click the continue button
dummy

Hard to see from this image but you can see the "Not you?" text under the button
dummy

I think this details page will also need to be wrapped into a scrollview for smaller screen sizes.

Signed-off-by: Mac Deluca <Mac.Deluca@quartech.com>
Signed-off-by: Mac Deluca <Mac.Deluca@quartech.com>
Signed-off-by: Mac Deluca <Mac.Deluca@quartech.com>
@MacDeluca
Copy link
Contributor Author

I saw some oddities while testing this locally on my android device: this might just be a test date issue but the privacy notice didn't link anywhere

After verification and navigating to the BC Services Card with the login, this is what I see when I click the continue button

Hard to see from this image but you can see the "Not you?" text under the button

I think this details page will also need to be wrapped into a scrollview for smaller screen sizes.

All these issues have been addressed.

note: It does appear that the login service for the BC Services Card Account is temp down https://idsit.gov.bc.ca/login/initiate

Signed-off-by: Mac Deluca <Mac.Deluca@quartech.com>
Copy link

@al-rosenthal al-rosenthal self-requested a review September 16, 2025 19:45
@al-rosenthal al-rosenthal merged commit 3c996e9 into main Sep 16, 2025
19 checks passed
@al-rosenthal al-rosenthal deleted the md_bcsc_2563_services_catalogue branch September 16, 2025 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants