-
Notifications
You must be signed in to change notification settings - Fork 62
feat: BCSC service catalogue (issue #2563) #2668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Mac Deluca <Mac.Deluca@quartech.com>
Signed-off-by: Mac Deluca <Mac.Deluca@quartech.com>
Signed-off-by: Mac Deluca <Mac.Deluca@quartech.com>
Signed-off-by: Mac Deluca <Mac.Deluca@quartech.com>
Signed-off-by: Mac Deluca <Mac.Deluca@quartech.com>
Signed-off-by: Mac Deluca <Mac.Deluca@quartech.com>
Signed-off-by: Mac Deluca <Mac.Deluca@quartech.com>
Signed-off-by: Mac Deluca <Mac.Deluca@quartech.com>
Signed-off-by: Mac Deluca <Mac.Deluca@quartech.com>
Signed-off-by: Mac Deluca <Mac.Deluca@quartech.com>
Signed-off-by: Mac Deluca <Mac.Deluca@quartech.com>
Signed-off-by: Mac Deluca <Mac.Deluca@quartech.com>
Signed-off-by: Mac Deluca <Mac.Deluca@quartech.com>
Signed-off-by: Mac Deluca <Mac.Deluca@quartech.com>
Signed-off-by: Mac Deluca <Mac.Deluca@quartech.com>
Signed-off-by: Mac Deluca <Mac.Deluca@quartech.com>
Signed-off-by: Mac Deluca <Mac.Deluca@quartech.com>
Signed-off-by: Mac Deluca <Mac.Deluca@quartech.com>
Signed-off-by: Mac Deluca <Mac.Deluca@quartech.com>
Signed-off-by: Mac Deluca <Mac.Deluca@quartech.com>
Signed-off-by: Mac Deluca <Mac.Deluca@quartech.com>
Signed-off-by: Mac Deluca <Mac.Deluca@quartech.com>
Signed-off-by: Mac Deluca <Mac.Deluca@quartech.com>
Signed-off-by: Mac Deluca <Mac.Deluca@quartech.com>
Signed-off-by: Mac Deluca <Mac.Deluca@quartech.com>
Signed-off-by: Mac Deluca <Mac.Deluca@quartech.com>
Signed-off-by: Mac Deluca <Mac.Deluca@quartech.com>
Signed-off-by: Mac Deluca <Mac.Deluca@quartech.com>
Signed-off-by: Mac Deluca <Mac.Deluca@quartech.com>
Signed-off-by: Mac Deluca <Mac.Deluca@quartech.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pr rocks 🎸
}, | ||
}) | ||
|
||
// TODO (MD): implement a loading UI |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not for this PR but maybe in a future improvement; I think just a centered <ActivityIndicator size={'large'} />
is good enough in most cases and is similar to the current BCSC's loading mechanics
@bryce-mcmath Thanks for the review :) I'm just filling in some missing tests, I can ping you when I have all my changes in. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I saw some oddities while testing this locally on my android device:
this might just be a test date issue but the privacy notice didn't link anywhere
After verification and navigating to the BC Services Card with the login, this is what I see when I click the continue button
Hard to see from this image but you can see the "Not you?" text under the button
I think this details page will also need to be wrapped into a scrollview for smaller screen sizes.
Signed-off-by: Mac Deluca <Mac.Deluca@quartech.com>
Signed-off-by: Mac Deluca <Mac.Deluca@quartech.com>
…bcgov/bc-wallet-mobile into md_bcsc_2563_services_catalogue
Signed-off-by: Mac Deluca <Mac.Deluca@quartech.com>
Signed-off-by: Mac Deluca <Mac.Deluca@quartech.com>
Signed-off-by: Mac Deluca <Mac.Deluca@quartech.com>
All these issues have been addressed. note: It does appear that the login service for the BC Services Card Account is temp down https://idsit.gov.bc.ca/login/initiate |
Signed-off-by: Mac Deluca <Mac.Deluca@quartech.com>
|
Summary of Changes
This PR re-introduces the Service catalogue in the single app (BCSC). It also includes a new searching functionality that did not exist previously. The list now fetches from IAS and filters based on the users card type (ie: BCSCCardProcess)
useFilterServiceClients
- it fetches and filters the service clients based on a config.useDebounce
- used to delay the filtering of the serviceClients till after the user has stopped typingServiceLoginScreen
- either provides information of the service or allows quick loginTesting Notes
Screenshots, videos, or gifs
Related Issues
#2563
Pull Request Checklist
Tick all boxes below to demonstrate that you have completed the respective task. If the item does not apply to your this PR check it anyway to make it apparent that there's nothing to do.
Signed-off-by
line (we use the DCO GitHub app to enforce this)