Fix code scanning alert no. 2: DOM text reinterpreted as HTML #186
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
|
I'll have to manually intervene here to get past the Lint errors triggered by the automated fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/bcgov/bcgov-wordpress-block-theme/security/code-scanning/2
To fix the problem, we need to ensure that any text content used in constructing HTML is properly escaped to prevent XSS attacks. This can be achieved by using a function to escape HTML special characters before assigning the content to
innerHTML.headingCounter.innerTextbefore including it in the HTML string.Suggested fixes powered by Copilot Autofix. Review carefully before merging.