chore: more docs

Author: pbastia

docs/2024_code_review.md

@@ -1,3 +1,5 @@
+# Looking for '2024' in the app
+
 ## Registration
 
 - Date of first shipment for operations \*\*\*
@@ -30,7 +32,7 @@
     - allocated_for_compliance_2024 is calculated no matter what (along with the general compliance value)
     - "emissions attributable for compliance" and each products "allocated compliance emissions" use the 2024-specific value
     - excess/credited emissions also use the 2024-specific allocation
-    - tests for compliance service (test_compliance_service_static.py) also only test 2024 scenarios
+    - tests for compliance service (test_compliance_service_static.py, infrastrucutre.py) also only test 2024 scenarios
 
 ## Service
 
@@ -50,3 +52,26 @@
   - jsonSchema/complianceSummary.ts
 
 - lots of compliance tests use 2024 as a base when they don't really have to
+
+### Registration:
+
+    - View Facility: Did this facility begin operations in 2024 or 2025?
+    - Create Facility: Did this facility begin operations in 2024 or 2025?
+    - New entrant: date of first shipment is before or after Apr 1 2024?
+
+### Reporting
+
+    - Reporting a product will always show the Jan-Apr production
+
+# `ReportingYearService'
+
+- Could throw an exception if there is no reporting year defined for the current date
+- Could also include the ReportingYearDataAccessService functionality (or inversely)
+
+# `ReportingYear` model
+
+- Report validation tests use 2024 as a base year, which may or may not be special
+
+# Recommendations
+
+- make clear to the user what the current reporting year is, from the dashboard to all the relevant views