chore: do not validate allocations when methodology is N/A

Author: acatchpole

bc_obps/reporting/service/report_validation/validators/report_emission_allocation_validator.py

@@ -8,20 +8,34 @@
 
 
 def validate(report_version: ReportVersion) -> dict[str, ReportValidationError]:
+    """
+    Validates emission allocation data for all facility reports associated with a given report version.
+
+    For each facility report, checks that the sum of allocated emission quantities for each product category
+    matches the reported emission total, unless the allocation methodology is "Not applicable".
+    Returns a dictionary of errors keyed by facility and emission category if mismatches are found.
+
+    Args:
+        report_version (ReportVersion): The report version to validate.
+
+    Returns:
+        dict[str, ReportValidationError]: A dictionary of validation errors, keyed by facility and category.
+    """
 
     facility_reports = FacilityReport.objects.filter(report_version=report_version)
 
     errors = {}
 
     for fr in facility_reports:
         emission_data = ReportEmissionAllocationService.get_emission_allocation_data(report_version.id, fr.facility_id)
-        for category in emission_data.report_product_emission_allocations:
-            total_allocated = sum(product.allocated_quantity for product in category.products)
-            if total_allocated != category.emission_total:
-                errors[
-                    f"facility_{fr.facility_id}_category_{category.emission_category_id}_allocation_mismatch"
-                ] = ReportValidationError(
-                    Severity.ERROR,
-                    f"Allocated emissions for {fr.facility_name} in '{category.emission_category_name}' category do not match reported emissions.",
-                )
+        if emission_data.allocation_methodology != "Not applicable":
+            for category in emission_data.report_product_emission_allocations:
+                total_allocated = sum(product.allocated_quantity for product in category.products)
+                if total_allocated != category.emission_total:
+                    errors[
+                        f"facility_{fr.facility_id}_category_{category.emission_category_id}_allocation_mismatch"
+                    ] = ReportValidationError(
+                        Severity.ERROR,
+                        f"Allocated emissions for {fr.facility_name} in '{category.emission_category_name}' category do not match reported emissions.",
+                    )
     return errors