Skip to content

Commit f0698fc

Browse files
committed
fix: development branch merge conflict resolution
2 parents bd1f48c + 772798d commit f0698fc

File tree

194 files changed

+25723
-2078
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

194 files changed

+25723
-2078
lines changed

.github/workflows/ci.yml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,9 @@ jobs:
3939
steps:
4040
- uses: actions/checkout@v2
4141
- uses: actions/setup-node@v2
42+
with:
43+
node-version: "16"
44+
cache: "yarn"
4245
- run: yarn
4346
- run: pip install pre-commit
4447
- run: pre-commit run --all-files -v

.gitignore

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -39,3 +39,6 @@ yarn-error.log
3939

4040
# TypeScript
4141
tsconfig.tsbuildinfo
42+
43+
.specstory/
44+
.cursor/

README.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -209,6 +209,7 @@ npm run <SCRIPT_NAME>
209209
| `back-end:start` | Starts the back-end server (assumes it has already been built by grunt). |
210210
| `back-end:build` | Builds the back-end server using grunt. |
211211
| `back-end:watch` | Builds and starts the back-end server inside a nodemon process, rebuilding and restarting it whenever a back-end or shared source file changes. |
212+
| `back-end:debug-watch` | Similar to back-end:debug but generates source maps to enable IDE debugging of the API project
212213
| `back-end:typedoc` | Builds TypeDoc API documentation for the back-end source code. |
213214
| `shared:lint` | Lints the shared source code using eslint. |
214215
| `shared:typedoc` | Builds TypeDoc API documentation for the shared source code. |
@@ -411,4 +412,4 @@ The Digital Marketplace is currently operated by the Procurement Services Branch
411412

412413
## Credits
413414

414-
This project would not have been possible by the incredible work done by open source project maintainers. The licenses for open source projects used by the Procurement Concierge Program's web app are documented in `docs/open-source-licenses.txt`.
415+
This project would not have been possible by the incredible work done by open source project maintainers. The licenses for open source projects used are documented in `docs/open-source-licenses.txt`.

docs/local-development/debug-config.md

Lines changed: 16 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -81,11 +81,16 @@ Debugging the front-end might require evaluating MSG's in the state object.
8181
- running locally
8282
- command line access
8383

84-
1. Run the following:
85-
`NODE_ENV=development npm run back-end:watch`
84+
### Regular Development (without source maps)
8685

86+
Run the following for normal development:
87+
```bash
88+
NODE_ENV=development npm run back-end:watch
89+
```
90+
91+
This will display server logs:
8792

88-
``` bash
93+
```bash
8994
[request:76d1029e-445a-46b1-a45b-db34cdefbac4] -> GET /images/illustrations/sprint_with_us.svg sessionId="anonymous"
9095
[request:76d1029e-445a-46b1-a45b-db34cdefbac4] <- 200 1ms
9196
[request:b7c10e3f-5bd9-49f7-a82f-3d4d21e2b042] -> GET /images/illustrations/collaboration_work.svg sessionId="anonymous"
@@ -99,3 +104,11 @@ Debugging the front-end might require evaluating MSG's in the state object.
99104
[hooks] Invoked cwuCrudHook at Thu Nov 24 2022 16:02:55 GMT-0800 (Pacific Standard Time)
100105
[hooks] Invoked swuCrudHook at Thu Nov 24 2022 16:02:55 GMT-0800 (Pacific Standard Time)
101106
```
107+
108+
### Debugging with Source Maps
109+
110+
For debugging with IDE integration and source maps, use the following:
111+
112+
In your IDE, set up a debug configuration that connects to your Node.js application. For VS Code You can use the pre-configured 'Run Script:back-end:debug' command, which will automatically start and attach to the debug session. This allows you to set breakpoints, inspect variables, and step through your back-end code.
113+
114+
This setup uses a separate `tsconfig.debug.json` configuration that only generates source maps when needed for debugging.

docs/onboarding.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -176,7 +176,7 @@ To watch for source file changes and rebuild the back-end during local developme
176176
| `src/back-end/lib/hooks/code-with-us.ts` | A hook that automatically marks Code With Us opportunities as ready for evaluation. This hook is run on a per-request basis and is throttled to limit resource utilization. |
177177
| `src/back-end/lib/hooks/logger.ts` | A hook that logs each request and response. |
178178
| `src/back-end/lib/hooks/sprint-with-us.ts` | A hook that automatically marks Sprint With Us opportunities as ready for evaluation. This hook is run on a per-request basis and is throttled to limit resource utilization. |
179-
| `src/back-end/lib/mailer/notifications/` | Modules that export individual email notifications. |
179+
| `src/back-end/lib/mailer/notifications/` | Modules that export individual email notifications. **Note:** There is a discrepancy in how contract dates are displayed in opportunity award emails across the three opportunity types. CWU opportunities have `startDate` and `completionDate` fields but do not include them in award emails, while TWU opportunities include them. |
180180
| `src/back-end/lib/mailer/index.tsx` | Exports general types for representing transactional emails. |
181181
| `src/back-end/lib/mailer/templates.tsx` | Exports types, functions and React views for rendering email notifications. |
182182
| `src/back-end/lib/mailer/transport.ts` | Exports types and functions for sending transactional emails using `nodemailer`. |

package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@
2727
"back-end:start": "node build/back-end/back-end/start.js",
2828
"back-end:build": "npx grunt back-end-build",
2929
"back-end:watch": "npx nodemon --watch ./src/back-end --watch ./src/shared --ext ts,tsx,js,json,yaml --exec \"npx grunt back-end-build-development && npm run back-end:start\"",
30+
"back-end:debug-watch": "npx nodemon --watch ./src/back-end --watch ./src/shared --ext ts,tsx,js,json,yaml --exec \"npx tsc --project src/back-end/tsconfig.debug.json --outDir build/back-end && npm run back-end:start\"",
3031
"back-end:typedoc": "npx typedoc --name 'Digital Marketplace Back-End' --tsconfig src/back-end/tsconfig.json --cleanOutputDir --out typedoc/back-end --excludeExternals --entryPointStrategy expand src/back-end",
3132
"shared:lint": "npx eslint -c .eslintrc.js src/shared && echo Lint Successful\n",
3233
"shared:typedoc": "npx typedoc --name 'Digital Marketplace Shared' --tsconfig src/shared/tsconfig.json --cleanOutputDir --out typedoc/shared --excludeExternals --entryPointStrategy expand src/shared",

src/back-end/config.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,9 +8,9 @@ import { parseBooleanEnvironmentVariable } from "shared/config";
88

99
// HARDCODED CONFIG
1010
// Offset for total opportunity metrics displayed on landing page
11-
export const TOTAL_AWARDED_COUNT_OFFSET = 94;
11+
export const TOTAL_AWARDED_COUNT_OFFSET = 93;
1212

13-
export const TOTAL_AWARDED_VALUE_OFFSET = 13211500;
13+
export const TOTAL_AWARDED_VALUE_OFFSET = 13736500;
1414

1515
export const DB_MIGRATIONS_TABLE_NAME = "migrations";
1616

src/back-end/index.ts

Lines changed: 17 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,14 @@ import sessionResource from "back-end/lib/resources/session";
4141
import codeWithUsSubscriberResource from "back-end/lib/resources/subscribers/code-with-us";
4242
import sprintWithUsSubscriberResource from "back-end/lib/resources/subscribers/sprint-with-us";
4343
import teamWithUsSubscriberResource from "back-end/lib/resources/subscribers/team-with-us";
44+
import sprintWithUsProposalTeamQuestionEvaluationResource from "back-end/lib/resources/proposal/sprint-with-us/team-questions/evaluations";
45+
import sprintWithUsOpportunityTeamQuestionEvaluationResource from "back-end/lib/resources/opportunity/sprint-with-us/team-questions/evaluations";
46+
import sprintWithUsProposalTeamQuestionConsensusResource from "back-end/lib/resources/proposal/sprint-with-us/team-questions/consensus";
47+
import sprintWithUsOpportunityTeamQuestionConsensusResource from "back-end/lib/resources/opportunity/sprint-with-us/team-questions/consensus";
48+
import teamWithUsProposalResourceQuestionEvaluationResource from "back-end/lib/resources/proposal/team-with-us/resource-questions/evaluations";
49+
import teamWithUsOpportunityResourceQuestionEvaluationResource from "back-end/lib/resources/opportunity/team-with-us/resource-questions/evaluations";
50+
import teamWithUsProposalResourceQuestionConsensusResource from "back-end/lib/resources/proposal/team-with-us/resource-questions/consensus";
51+
import teamWithUsOpportunityResourceQuestionConsensusResource from "back-end/lib/resources/opportunity/team-with-us/resource-questions/consensus";
4452
import userResource from "back-end/lib/resources/user";
4553
import adminRouter from "back-end/lib/routers/admin";
4654
import authRouter from "back-end/lib/routers/auth";
@@ -160,7 +168,15 @@ export function createRouter(connection: Connection): AppRouter {
160168
sessionResource,
161169
userResource,
162170
metricsResource,
163-
emailNotificationsResource
171+
emailNotificationsResource,
172+
sprintWithUsProposalTeamQuestionEvaluationResource,
173+
sprintWithUsOpportunityTeamQuestionEvaluationResource,
174+
sprintWithUsProposalTeamQuestionConsensusResource,
175+
sprintWithUsOpportunityTeamQuestionConsensusResource,
176+
teamWithUsProposalResourceQuestionEvaluationResource,
177+
teamWithUsOpportunityResourceQuestionEvaluationResource,
178+
teamWithUsProposalResourceQuestionConsensusResource,
179+
teamWithUsOpportunityResourceQuestionConsensusResource
164180
];
165181

166182
// Define CRUD routes.

0 commit comments

Comments
 (0)