Update file.ts #495
Merged
Update file.ts #495
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Increase max file name length to 255, aligning with OS standard
IanFonzie
reviewed
Mar 27, 2025
src/shared/lib/validation/file.ts
Outdated
| validExtensions: readonly string[] = [] | ||
| ): Validation<string> { | ||
| const validatedName = validateGenericString(name, "File name"); | ||
| const validatedName = validateGenericString(name, "File name", 1, 255); |
There was a problem hiding this comment.
Would it help to have a comment here or a more explicit variable name explaining why we used 255 so that we don't have to refer to the PR later?
|
IanFonzie
approved these changes
Apr 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes issue: [DM-497]
Includes tests? [N]
Updated docs? [N]
Proposed changes:
change max character length
Additional notes:
256 is generally OS max file name length