-
Notifications
You must be signed in to change notification settings - Fork 22
Feat/delete evaluators or chair #499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/delete evaluators or chair #499
Conversation
3af2048
to
4a4e9e4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
EvaluationTeamQuestionsChairSubmission = "EVAL_QUESTIONS_CHAIR_SUBMISSION", | ||
EvaluationTeamQuestionsAdminReview = "EVAL_QUESTIONS_ADMIN_REVIEW", | ||
EvaluationTeamQuestions = "EVAL_QUESTIONS", // TODO: Remove | ||
EvaluationTeamQuestions = "EVAL_QUESTIONS", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, much simpler
isValidEvaluationStatusChange as IsValidQuestionEvaluationStatusChange, | ||
isValidConsensusStatusChange as IsValidQuestionConsensusStatusChange, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think you need these import aliases any more as...
|
Includes tests? [N]
Updated docs? [N]
Proposed changes:
Additional notes: