Skip to content

Conversation

IanFonzie
Copy link
Collaborator

@IanFonzie IanFonzie commented Apr 4, 2025

Includes tests? [N]
Updated docs? [N]

Proposed changes:

  • Support deleting Evaluators from, or the changing the Evaluation Chair on, an opportunity any time before all individual evaluations have been submitted for all of an opportunity's proposals.
  • Add "Evaluation Panel" tab to "edit opportunity" page. This tab supports management of panel until the opportunity has consensus submitted.
  • Allow an individual Evaluator so edit a draft evaluation for a proposal, but do not allow them to edit an evaluation after submitting it.
  • Allow an Evaluation Chair to edit consensus after it has been submitted, but before the opportunity transitions past the question-evaluation phase.

Additional notes:

  • Still some statuses for proposals and opportunities to remove; will address those in the migration for backwards compatibility

@IanFonzie IanFonzie force-pushed the feat/delete-evaluators-or-chair branch from 3af2048 to 4a4e9e4 Compare April 4, 2025 22:11
@IanFonzie IanFonzie changed the base branch from development to in-app-evaluation April 4, 2025 22:11
@IanFonzie IanFonzie requested a review from dhruvio April 4, 2025 22:12
Copy link
Collaborator

@dhruvio dhruvio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

EvaluationTeamQuestionsChairSubmission = "EVAL_QUESTIONS_CHAIR_SUBMISSION",
EvaluationTeamQuestionsAdminReview = "EVAL_QUESTIONS_ADMIN_REVIEW",
EvaluationTeamQuestions = "EVAL_QUESTIONS", // TODO: Remove
EvaluationTeamQuestions = "EVAL_QUESTIONS",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, much simpler

Comment on lines 51 to 52
isValidEvaluationStatusChange as IsValidQuestionEvaluationStatusChange,
isValidConsensusStatusChange as IsValidQuestionConsensusStatusChange,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think you need these import aliases any more as...

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
1 Security Hotspot
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@IanFonzie IanFonzie merged commit eda0942 into in-app-evaluation Apr 15, 2025
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants