-
Notifications
You must be signed in to change notification settings - Fork 22
Refactor/optimize page loading #507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 11 commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
f416f65
initial optimization pass
kmandryk e681ff9
refactor: add loading icon for user page
kmandryk 817830d
refactor: table virtualization
kmandryk a68f357
Merge branch 'development' into refactor/optimize-page-loading
alex-struk 1487d80
fix: restored same columns as in original code
alex-struk 6b9d64a
feat: added search feature
alex-struk c0c2530
refactor: moved VirtualizedTable to separate file, aligned with front…
alex-struk d7c3c4a
refactor: standardized new component, fixed scrolling after search
alex-struk e088e22
fix: sonarqube fixes
alex-struk 1262b53
fix: development branch merge conflict fixes
alex-struk 222373f
fix: import fixes
alex-struk 1adca67
refactor: created a re-usable virtualized-table component
alex-struk 787b91e
refactor: eliminated the use of a separate table object for the purpo…
alex-struk 81d2538
refactor: fixed magic numbers, removed tooltips, fixed scroll reset, …
alex-struk 19a34d1
refactor: clean up to align with orignal code
alex-struk 5787767
refactor: clean up
alex-struk 0d425c7
refactor: minor reversion
alex-struk bf9e200
refactor: function rename
alex-struk dffb4a9
refactor: cleanup
alex-struk f472d36
refactor: removed td tooltip logic
alex-struk d6b9c7e
refactor: minor alignment to framework
alex-struk 990b62d
refactor: removed null from ADT definitions
alex-struk cdd436a
refactor: removed resetScroll event and replaced logic with initializ…
alex-struk 7475bf2
refactor: removed unnecessary argument from connection.raw calls
alex-struk File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,67 @@ | ||
| /* Wrapper for the fixed header table */ | ||
| .virtualized-table-header-wrapper { | ||
| // Headers should not scroll | ||
| overflow: hidden; | ||
| border: 1px solid #dee2e6; // Match body container border | ||
| border-bottom: none; // Avoid double border | ||
| border-radius: 4px 4px 0 0; // Match body container corners | ||
| } | ||
|
|
||
| /* Header table specific styles */ | ||
| .virtualized-table-header-fixed { | ||
| margin-bottom: 0 !important; // Remove default table margin | ||
| width: 100%; | ||
| table-layout: fixed; | ||
| background-color: #f8f9fa; // Header background | ||
|
|
||
| thead th { | ||
| // No longer sticky, relies on table-header-wrapper not scrolling | ||
| background: inherit; // Inherit from thead if set, or set here | ||
| border-bottom: 2px solid #dee2e6; | ||
| vertical-align: middle; | ||
| padding: 0.75rem; | ||
| white-space: nowrap; | ||
| overflow: hidden; | ||
| text-overflow: ellipsis; | ||
| text-align: left; | ||
|
|
||
| // Apply width from colgroup in body for consistency (via fixed layout) | ||
| } | ||
| } | ||
|
|
||
| /* Scrollable container for the table body */ | ||
| .virtualized-body-container { | ||
| position: relative; // Needed for absolute positioning inside | ||
| height: 550px; // Fixed height for body (600px total - header height approx) | ||
| overflow-y: auto; // Enable vertical scroll | ||
| overflow-x: hidden; // Prevent horizontal scroll if columns fit | ||
| border: 1px solid #dee2e6; | ||
| border-top: none; // Connects with header wrapper border | ||
| border-radius: 0 0 4px 4px; // Match header wrapper corners | ||
| } | ||
|
|
||
| /* Body table specific styles (rendered inside positioned div) */ | ||
| .virtualized-body-table { | ||
| margin-bottom: 0; | ||
| width: 100%; | ||
| table-layout: fixed; | ||
| background-color: white; | ||
|
|
||
| tbody { | ||
| tr { | ||
| // Height is set inline on <tr> for virtualization | ||
| &:hover { | ||
| background-color: rgba(0, 0, 0, 0.075); | ||
| } | ||
| } | ||
|
|
||
| td { | ||
| vertical-align: middle; | ||
| padding: 0.75rem; | ||
| border-top: 1px solid #dee2e6; | ||
| white-space: nowrap; | ||
| overflow: hidden; | ||
| text-overflow: ellipsis; | ||
| } | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,7 @@ | ||
| // Imports | ||
|
|
||
| @import "./font"; | ||
| @import "./components/virtualized-table"; | ||
|
|
||
| // Custom Bootstrap variable overrides. | ||
|
|
||
|
|
||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.