Merged
Conversation
…r recording email status and metadata. - Added email tracking integration to email sending methods. - Implemented CHES email status polling task to update email tracking records.
…UUID, removed `error_code`, and updated corresponding tests and scripts.
matbusby-fw
force-pushed
the
mds-6632-email-tracking
branch
from
0d52217 to
dcdb35f
Compare
matbusby-fw
added
the
👍 Ready for review
taraepp
reviewed
Oct 14, 2025
taraepp
reviewed
Oct 14, 2025
migrations/sql/V2025.09.23.09.45__create_email_tracking_table.sql
Outdated
Show resolved
Hide resolved
taraepp
reviewed
Oct 14, 2025
taraepp
reviewed
Oct 14, 2025
...api/app/api/projects/information_requirements_table/models/information_requirements_table.py
Outdated
Show resolved
Hide resolved
Contributor
|
Overall it looks good to me! I have some nitpicks, which I suspect are more directed at copilot. |
simensma-fresh
requested changes
Oct 15, 2025
…column type and a column name in the email_tracking table. Created a shared TaskBase. Updated celery task to be created with 'retry' rather than apply_async.
|
taraepp
approved these changes
Oct 16, 2025
simensma-fresh
approved these changes
Oct 16, 2025
matbusby-fw
added a commit
that referenced
this pull request
Oct 17, 2025
This reverts commit c3df500.
matbusby-fw
added a commit
that referenced
this pull request
Oct 17, 2025
matbusby-fw
pushed a commit
that referenced
this pull request
Oct 20, 2025
matbusby-fw
added a commit
that referenced
this pull request
Oct 20, 2025
matbusby-fw
added a commit
that referenced
this pull request
Nov 5, 2025
* - Introduced email tracking model and associated migration scripts for recording email status and metadata. - Added email tracking integration to email sending methods. - Implemented CHES email status polling task to update email tracking records. * Refactored email tracking model: replaced `ches_transaction_id` with UUID, removed `error_code`, and updated corresponding tests and scripts. * Updated template email tracking default to false * restore retries to sql migration * update enum values * remove import * more enum fixes * fixed missing comma * fixed irt test * fixed application_emails test * fixed application_emails test * address PR comments. Set email tracking to always be done. Updated a column type and a column name in the email_tracking table. Created a shared TaskBase. Updated celery task to be created with 'retry' rather than apply_async. * removed not null from email tracking reference id and table * removed not null from email tracking reference id and table * Add `db_session` to email service integration test parameters --------- Co-authored-by: mat <matbusby@gmail.com>
matbusby-fw
added a commit
that referenced
this pull request
Nov 5, 2025
matbusby-fw
added a commit
that referenced
this pull request
Nov 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Implement the ability to track the status of emails that have sent through CHES.
email_trackingMDS-6632
Why are you making this change? Provide a short explanation and/or screenshots