Skip to content

Conversation

braydencstratusadv
Copy link
Collaborator

No description provided.

@braydencstratusadv braydencstratusadv marked this pull request as draft September 26, 2025 01:26
@braydencstratusadv braydencstratusadv marked this pull request as ready for review September 26, 2025 01:47
Copy link
Collaborator

@bferguso bferguso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bferguso
Copy link
Collaborator

bferguso commented Oct 3, 2025

@braydencstratusadv - I've rebased this branch with what is in main. We're getting a cyclic redirect now - do you mind tracking that down?

@braydencstratusadv
Copy link
Collaborator Author

@braydencstratusadv - I've rebased this branch with what is in main. We're getting a cyclic redirect now - do you mind tracking that down?

I got it to pass on build_feature_branch.

This was tough to debug. All of the tests passed locally. I spent a decent amount of time trying to reproduce the environment locally, but couldn't do it.

I changed the test_expired_session_is_not_valid test to manually redirect, instead of letting Django handle it. It's possible that our settings override is creating a mismatch so the /bcap/index.htm may not exist when we're testing, so I handle 404s and prevent infinite looping by tracking where we've been. This should still validate that we're not leaking OAuth tokens.

@bferguso
Copy link
Collaborator

bferguso commented Oct 3, 2025

Nice - thanks for sorting this out! We can look into why the settings are different at some point but this unblocks us for now.

@bferguso bferguso merged commit b469d24 into main Oct 3, 2025
7 of 8 checks passed
@bferguso bferguso deleted the blc/bugfix/cicd_pipeline branch October 3, 2025 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants