Audit Log In Detail Pages #1025
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
This is looking really great! I'm only seeing audit columns in the General Remarks table - should I be seeing others? If not we can get this merged in once the minor changes are made and then build on the fields that are displayed in a subsequent PR.
Maybe it's an idea to show/hide the audit columns - we could target them with CSS to manage visibility? Once again - just an idea for a future PR.
Once this is done and working, maybe we should move some of the generic components (view, url) to bcgov-arches-common so that it can be leveraged by other apps.
| def _get_nodegroup_id_from_alias(self, graph: str, alias: str) -> str | None: | ||
| with connection.cursor() as cursor: | ||
| query = """ | ||
| SELECT DISTINCT n.nodegroupid::text |
There was a problem hiding this comment.
The graphs are now versioned so we need to filter by graphs.sourceidentifier is null.
Maybe we could use something like this to make it more Django-y?:
https://github.com/archesproject/arches-component-lab/blob/16b55f4a86f0b4c29222cf8baedb86d4aac92408/arches_component_lab/views/node_config_mixin.py#L30-L33
|
|
||
| <template> | ||
| <Button | ||
| :label="loading ? 'Loading...' : 'Populate All Entered On/By Fields'" |
There was a problem hiding this comment.
How about something like "Audit info" with an open / slash eye?
| AliasedNodeData, | ||
| } from '@/arches_component_lab/types.ts'; | ||
|
|
||
| export interface EditLogEntry { |
There was a problem hiding this comment.
Let's pull these interfaces out into the src/bcgov_arches_common/types.ts file, and include all attributes that are returned by the view?
Maybe we should extend the AlaisedNodeData to have an audit field (or something similar) so it can be strongly typed in Vue components?.
| export function applyEditLogToTile( | ||
| tile: AliasedTileData, | ||
| editLogData: EditLogData | undefined, | ||
| enteredOnField = 'entered_on', |
There was a problem hiding this comment.
Constants could be pulled out into a constants.ts file at the same level as the types.ts
| export function useSingleTileEditLog( | ||
| sourceData: Ref<AliasedTileData | undefined>, | ||
| editLogData: Ref<EditLogData | undefined>, | ||
| options?: { |
There was a problem hiding this comment.
Can we default this value in the parameter list so we don't have to check for them in the body?
| ) { | ||
| const processedData = ref<AliasedTileData | null>(null); | ||
|
|
||
| const enteredOnField = options?.enteredOnField || 'entered_on'; |
There was a problem hiding this comment.
Lets use the constants you defined above.
ArchaeologicalSiteandSiteVisitdetail pages to populate "Entered By" and "Entered On" fields upon clicking it.