wfprev-614 add pagination to feature endpoint. make it capable to search by projectGuid #1010
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
yzlucas
changed the title
sukhpalp
requested changes
Oct 3, 2025
| query.distinct(true); | ||
|
|
||
| return entityManager.createQuery(query).getResultList(); | ||
| return entityManager.createQuery(query) |
There was a problem hiding this comment.
I think we should have an orderBy here so that the pagination results are more consistent and there fewer chances for duplicate results.
There was a problem hiding this comment.
Done, added sortby and default to projectName asc
sukhpalp
approved these changes
Oct 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://apps.nrs.gov.bc.ca/int/jira/browse/WFPREV-614