WFPREV-775 & 776 fix project download issues #963
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sukhpalp
reviewed
Sep 2, 2025
| if (fuelData.isEmpty() && crxData.isEmpty()) { | ||
| log.info("[{}] [xlsx] no data for given projectGuids", rid); | ||
| throw new IllegalArgumentException("No data found for the provided projectGuids."); | ||
| private static class ReportDataBundle { |
There was a problem hiding this comment.
Be sure to add this in reflection and serialization files
| } | ||
| } | ||
|
|
||
| private CulturalPrescribedFireReportEntity toCrxEntity( |
There was a problem hiding this comment.
should this be done in the entity class?
There was a problem hiding this comment.
Removed, we don't need this anymore after adding the unique row guid and using JPA to fetch rows with a null projectPlanFiscalGuid.
ssylver93
force-pushed
the
feature/WFPREV-775
branch
from
de3cd47 to
63359f3
Compare
kcguise
approved these changes
Sep 3, 2025
sukhpalp
approved these changes
Sep 3, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.