Handle Impact of Project Type Change on Evaluation Criteria Scores #986
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ssylver93
requested changes
Sep 26, 2025
| return 'Continue'; | ||
| } | ||
|
|
||
| get isDeleteDialog(): boolean { |
There was a problem hiding this comment.
I'd recommend to change this function name to isDeleteOrChangeDialog to reflect the functionality
| [optionLabelField]="'description'" | ||
| [tooltip]="getCodeDescription(CodeTableKeys.PROJECT_TYPE_CODE)" | ||
| [tooltip]="projectTypeLocked | ||
| ? 'Project Type cannot be changed after any Fiscal Activity has been Endorsed and Approved' |
There was a problem hiding this comment.
can this be moved to a communal file that holds messages rather than being hardcoded? like constants.ts
ssylver93
previously approved these changes
Sep 26, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://apps.nrs.gov.bc.ca/int/jira/browse/WFPREV-671
Delete EC Summary on changing the project type.
If project has fiscal with status falls into " prepared/in progress/complete/cancelled ", disable the project type