feat: optimize vault call (#65)

* feat: optimize vault call

* fix: test

Author: mbystedt

src/vault/vault-policy.controller.spec.ts

@@ -15,6 +15,7 @@ describe('vault-policy.controller', () => {
   const vault = {
     read: jest.fn(),
     write: jest.fn(),
+    policies: jest.fn(() => Promise.resolve({ data: { policies: [] } })),
   } as unknown as nv.client;
 
   const mockRegistrationService = {

src/vault/vault-policy.controller.ts

@@ -29,14 +29,19 @@ export default class VaultPolicyController {
    * Syncs policies to vault
    */
   public async sync(root: string[]): Promise<void> {
+    const policies = (await this.vault.policies()).data.policies as string[];
     for (const policyRoot of this.policyRootServices) {
       if (root.length === 0 || root[0] === policyRoot.getName()) {
         this.logger.info(`- Sync ${policyRoot.getName()}`);
         const specs = await policyRoot.build();
         for (const spec of specs) {
           await this.addPolicy(spec);
         }
-        await this.removeUnregisteredPolicies(policyRoot.getName(), false);
+        await this.removeUnregisteredPolicies(
+          policies,
+          policyRoot.getName(),
+          false,
+        );
       }
     }
     await this.registrationService.clear();
@@ -69,11 +74,10 @@ export default class VaultPolicyController {
    * @param partialRegistration True if not all policies were registered this run and false otherwise
    */
   public async removeUnregisteredPolicies(
+    policies: string[],
     group: string,
     partialRegistration: boolean,
   ): Promise<void> {
-    // eslint-disable-next-line @typescript-eslint/no-unsafe-member-access -- No typing avialable
-    const policies = (await this.vault.policies()).data.policies as string[];
     try {
       const policiesToRemove =
         await this.registrationService.filterNamesForUnregistered(