fix: auto release to PROD based on github release along with workflow… #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
There was a problem hiding this comment.
Pull Request Overview
This PR updates the PROD release workflow to support auto-releasing based on GitHub release events.
- Added a new release trigger for published releases.
- Updated output variable fallbacks and guarded steps with conditions to differentiate between release events and manual triggers.
Comments suppressed due to low confidence (2)
.github/workflows/release.yml:31
- Consider adding a comment to clarify why the Conventional Changelog Update step is skipped for release events. This can help future maintainers understand the intended workflow behavior when a GitHub release event occurs.
if: (github.event_name != 'release')
.github/workflows/release.yml:80
- Review whether the Github Release job should be skipped on release events given that the workflow is now triggered by release events. Adding inline documentation on this condition would clarify the intended behavior.
if: (needs.vars.outputs.tag != '' && github.event_name != 'release')
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.