fix: issues dry run #24
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
There was a problem hiding this comment.
Pull Request Overview
This PR implements fixes for issues identified during a dry run by unifying tagging conventions and ensuring consistency across Terraform and GitHub workflow configurations. Key changes include:
- Introduction of a common_tags variable and its usage throughout Terraform configurations.
- Addition of a new repo_name local variable in terragrunt.hcl files.
- Updates to GitHub workflow files to accommodate the new common_tags variable and repo_name attribute.
Reviewed Changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| terraform/frontend/terragrunt.hcl | Adds repo_name local and embeds common_tags into tfvars |
| terraform/database/terragrunt.hcl | Adds repo_name local and embeds common_tags into tfvars |
| terraform/api/terragrunt.hcl | Adds repo_name local and embeds common_tags into tfvars |
| infrastructure/frontend/* | Replaces inline tags with var.common_tags and updates bucket names |
| infrastructure/database/* | Introduces common_tags variable and uses it in resource configurations |
| infrastructure/api/* | Updates resource names and tagging while renaming certain attributes |
| AWS-DEPLOY.md | Updates steps and numbering in the deployment instructions |
| .github/workflows/* | Adds support for repo_name and includes changes for prod environment and prefix generation |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Overview
This PR implements fixes for issues identified during a dry run by unifying tagging conventions and ensuring consistency across Terraform and GitHub workflow configurations. Key changes include:
Reviewed Changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated 2 comments.
Show a summary per file