fix(optimizer): simplify redundant intersections in allOf schemas #672
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When a JSON Schema uses
allOfwith$refthat overlap, the generated TypeScript contains redundant intersections and duplicate properties.Example from the
tsconfig.jsonschema:This happens when:
$ref’d multiple times$refwraps the base in anallOfwith extra constraintsBefore
Changes
Optimizer (
optimizer.ts)A & (A | null)→A | null(A & (A | null))and(A | null) & AA & B & A & B → A & BGenerator (
generator.ts)Setexport typedeclarationsAfter