-
Notifications
You must be signed in to change notification settings - Fork 3
refactor package to remove sharp edges for schema authors/users (particularly @row
/ Row
) and improve API
#54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 8 commits
Commits
Show all changes
29 commits
Select commit
Hold shift + click to select a range
917fbb9
Add name and type util functions for schemas
OTDE 4ca4b42
Add tests for field name/type util functions
OTDE b42e64a
Invoke generated struct directly
OTDE def1138
Add dispatch on generated struct type
OTDE c4e0bb7
Undo accidental formatting
OTDE 304d017
Use consistent kwarg spacing
OTDE f8a3a13
Apply suggestions from code review
OTDE cbd1fcf
Remove fallback method errors for util functions
OTDE 176aa6f
Merge branch 'sc/column-name-utility-functions' of https://github.com…
OTDE 1158b56
Update tests to expect new error type
OTDE c9d7de5
refactor
jrevels 32b8663
fix typo
jrevels 44efde2
julia version compat fix
jrevels 3633d12
another julia compat fix
jrevels c2ea420
make comment consistent with code change
jrevels 5c5c044
fix field type escaping and add a test
jrevels 6ee2d8d
fix julia 1.3 compat issue again
jrevels 2906296
moar julia 1.3 compat fixes
jrevels 6b968c7
implement design proposal arising from #54 (#55)
jrevels f8b48fa
bump minimum Julia version to latest LTS minor version
jrevels c6c0d57
Update src/schemas.jl
jrevels 53be860
Update src/schemas.jl
jrevels b9eca8a
Update docs/src/schema-concepts.md
jrevels e3dd4c0
tweak err msg, fix tests
jrevels 5f8ec57
add additional syntax note
jrevels 2fe38fc
make sure to test nested (de)serialization of record types
jrevels 9fe8092
use record type names to drive version declaration, rather than ident…
jrevels 7315fd3
add a couple more nested serialization tests
jrevels e8b0cb4
Update docs/src/schema-concepts.md
jrevels File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.