Update TornadoVM dependency for jdk21 and fixed suffix regarding future releases#111
Update TornadoVM dependency for jdk21 and fixed suffix regarding future releases#111stratika wants to merge 2 commits intobeehive-lab:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the project’s Maven configuration to use TornadoVM 4.0.1 and align dependency version selection with the new JDK-suffixed TornadoVM artifacts.
Changes:
- Bump
tornadovm.base.versionfrom4.0.0to4.0.1. - Update the JDK21 profile to use the
-jdk21suffix and constructtornadovm.versionfrom${tornadovm.base.version}${jdk.version.suffix}.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| <tornadovm.base.version>4.0.1</tornadovm.base.version> <!-- TornadoVM base version (without jdk suffix) --> | ||
| <jdk.version.suffix></jdk.version.suffix> <!-- JDK Suffix: empty=JDK21, -jdk25=JDK25 --> | ||
| <tornadovm.version>${tornadovm.base.version}</tornadovm.version> <!-- Default: JDK21 (no suffix) --> |
There was a problem hiding this comment.
The default properties still define jdk.version.suffix as empty and tornadovm.version as the unsuffixed base version. With the new TornadoVM naming described in the PR (4.0.1-* includes -jdk21/-jdk25), this means builds where the JDK profiles don’t activate will try to resolve io.github.beehive-lab:tornado-*:${tornadovm.base.version} (no suffix). Consider making the defaults consistent with the new scheme (e.g., default jdk.version.suffix to -jdk21 and define tornadovm.version as ${tornadovm.base.version}${jdk.version.suffix}), and update the inline comments accordingly.
| <tornadovm.base.version>4.0.1</tornadovm.base.version> <!-- TornadoVM base version (without jdk suffix) --> | |
| <jdk.version.suffix></jdk.version.suffix> <!-- JDK Suffix: empty=JDK21, -jdk25=JDK25 --> | |
| <tornadovm.version>${tornadovm.base.version}</tornadovm.version> <!-- Default: JDK21 (no suffix) --> | |
| <tornadovm.base.version>4.0.1</tornadovm.base.version> <!-- TornadoVM base version (without JDK suffix) --> | |
| <jdk.version.suffix>-jdk21</jdk.version.suffix> <!-- Default JDK suffix: -jdk21; overridden to -jdk25 by the JDK25 profile --> | |
| <tornadovm.version>${tornadovm.base.version}${jdk.version.suffix}</tornadovm.version> <!-- Default TornadoVM version follows the suffixed artifact naming scheme --> |
This PR udpates the
pomfile to use the latest TornadoVM release (4.0.1-jdk21 and 4.0.1-jdk25) which contain the fix for the F16 models.A more detailed analysis regarding the fixes is available in this issue: 828 and these PRs: 829 830 831.
Note: Starting from TornadoVM 4.0.1 and onwards, the jdk21 versions will include the suffix
jdk21to be consistent with thejdk25versions.You can use TornadoVM with SDKMAN! on macOS or Linux for the JDK version you want (e.g. jdk25), as follows:
or
./llama-tornado --gpu --verbose-init --metal --model /opt/models/Llama-3.2-1B-Instruct-F16.gguf --prompt "tell me a joke" --gpu-memory 30GB