Skip to content

Update TornadoVM dependency for jdk21 and fixed suffix regarding future releases#111

Open
stratika wants to merge 2 commits intobeehive-lab:mainfrom
stratika:sync/tornadovm-4.0.1
Open

Update TornadoVM dependency for jdk21 and fixed suffix regarding future releases#111
stratika wants to merge 2 commits intobeehive-lab:mainfrom
stratika:sync/tornadovm-4.0.1

Conversation

@stratika
Copy link
Copy Markdown
Collaborator

@stratika stratika commented Apr 30, 2026

This PR udpates the pom file to use the latest TornadoVM release (4.0.1-jdk21 and 4.0.1-jdk25) which contain the fix for the F16 models.

A more detailed analysis regarding the fixes is available in this issue: 828 and these PRs: 829 830 831.

Note: Starting from TornadoVM 4.0.1 and onwards, the jdk21 versions will include the suffix jdk21 to be consistent with the jdk25 versions.

You can use TornadoVM with SDKMAN! on macOS or Linux for the JDK version you want (e.g. jdk25), as follows:

  • Use the new TornadoVM SDK version:
sdk install tornadovm 4.0.1-jdk25-opencl

or

sdk install tornadovm 4.0.1-jdk25-metal
  • Build GPULlama3.java:
make
  • Run an example:
./llama-tornado --gpu --verbose-init --metal --model /opt/models/Llama-3.2-1B-Instruct-F16.gguf --prompt "tell me a joke" --gpu-memory 30GB

@stratika stratika requested a review from orionpapadakis April 30, 2026 10:41
@stratika stratika self-assigned this Apr 30, 2026
@stratika stratika added the enhancement New feature or request label Apr 30, 2026
@stratika stratika changed the title Update TornadoVM dependency to jdk21 and fixed suffix for future releases Update TornadoVM dependency for jdk21 and fixed suffix regarding future releases Apr 30, 2026
@stratika stratika requested a review from mikepapadim April 30, 2026 10:55
@mikepapadim mikepapadim requested a review from Copilot April 30, 2026 11:02
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the project’s Maven configuration to use TornadoVM 4.0.1 and align dependency version selection with the new JDK-suffixed TornadoVM artifacts.

Changes:

  • Bump tornadovm.base.version from 4.0.0 to 4.0.1.
  • Update the JDK21 profile to use the -jdk21 suffix and construct tornadovm.version from ${tornadovm.base.version}${jdk.version.suffix}.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread pom.xml Outdated
Comment on lines 42 to 44
<tornadovm.base.version>4.0.1</tornadovm.base.version> <!-- TornadoVM base version (without jdk suffix) -->
<jdk.version.suffix></jdk.version.suffix> <!-- JDK Suffix: empty=JDK21, -jdk25=JDK25 -->
<tornadovm.version>${tornadovm.base.version}</tornadovm.version> <!-- Default: JDK21 (no suffix) -->
Copy link

Copilot AI Apr 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The default properties still define jdk.version.suffix as empty and tornadovm.version as the unsuffixed base version. With the new TornadoVM naming described in the PR (4.0.1-* includes -jdk21/-jdk25), this means builds where the JDK profiles don’t activate will try to resolve io.github.beehive-lab:tornado-*:${tornadovm.base.version} (no suffix). Consider making the defaults consistent with the new scheme (e.g., default jdk.version.suffix to -jdk21 and define tornadovm.version as ${tornadovm.base.version}${jdk.version.suffix}), and update the inline comments accordingly.

Suggested change
<tornadovm.base.version>4.0.1</tornadovm.base.version> <!-- TornadoVM base version (without jdk suffix) -->
<jdk.version.suffix></jdk.version.suffix> <!-- JDK Suffix: empty=JDK21, -jdk25=JDK25 -->
<tornadovm.version>${tornadovm.base.version}</tornadovm.version> <!-- Default: JDK21 (no suffix) -->
<tornadovm.base.version>4.0.1</tornadovm.base.version> <!-- TornadoVM base version (without JDK suffix) -->
<jdk.version.suffix>-jdk21</jdk.version.suffix> <!-- Default JDK suffix: -jdk21; overridden to -jdk25 by the JDK25 profile -->
<tornadovm.version>${tornadovm.base.version}${jdk.version.suffix}</tornadovm.version> <!-- Default TornadoVM version follows the suffixed artifact naming scheme -->

Copilot uses AI. Check for mistakes.
Comment thread pom.xml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants