Skip to content

Commit 5aaa234

Browse files
jp3peparkgang
authored andcommitted
deprecated된 kubectl 명령어 변경, slack slack notification 메시지 표시되도록 (#111)
* del: 환경변수를 가져오는 API endpoint 삭제 * up: npm 패키지 버전 업데이트 * up: 버전 정보 업데이트 * fix: deprecated 된 kubectl 때문에 발생한 배포 불가 문제 수정
1 parent bf964c4 commit 5aaa234

File tree

6 files changed

+20
-17
lines changed

6 files changed

+20
-17
lines changed

.github/workflows/aks-prod-deploy.yaml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ jobs:
4242

4343
- name: create namespace
4444
run: |
45-
kubectl create namespace ${{ env.NAMESPACE }} --dry-run -o json | kubectl apply -f -
45+
kubectl create namespace ${{ env.NAMESPACE }} --dry-run=client -o json | kubectl apply -f -
4646
4747
- name: aks apply object
4848
uses: Azure/k8s-deploy@v1.4
@@ -64,3 +64,4 @@ jobs:
6464
uses: rtCamp/action-slack-notify@v2
6565
env:
6666
SLACK_WEBHOOK: ${{ secrets.SLACK_WEBHOOK }}
67+
SLACK_MESSAGE: ${{ github.repository }}가 ${{ env.NAMESPACE }} 환경에 배포되었습니다 🚀

.github/workflows/aks-qa-deploy.yaml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ jobs:
3939

4040
- name: create namespace
4141
run: |
42-
kubectl create namespace ${{ env.NAMESPACE }} --dry-run -o json | kubectl apply -f -
42+
kubectl create namespace ${{ env.NAMESPACE }} --dry-run=client -o json | kubectl apply -f -
4343
4444
- name: aks apply object
4545
uses: Azure/k8s-deploy@v1.4
@@ -61,3 +61,4 @@ jobs:
6161
uses: rtCamp/action-slack-notify@v2
6262
env:
6363
SLACK_WEBHOOK: ${{ secrets.SLACK_WEBHOOK }}
64+
SLACK_MESSAGE: ${{ github.repository }}가 ${{ env.NAMESPACE }} 환경에 배포되었습니다 🚀

.github/workflows/aks-test-deploy.yaml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ jobs:
4141

4242
- name: create namespace
4343
run: |
44-
kubectl create namespace ${{ env.NAMESPACE }} --dry-run -o json | kubectl apply -f -
44+
kubectl create namespace ${{ env.NAMESPACE }} --dry-run=client -o json | kubectl apply -f -
4545
4646
- name: aks apply object
4747
uses: Azure/k8s-deploy@v1.4
@@ -63,3 +63,4 @@ jobs:
6363
uses: rtCamp/action-slack-notify@v2
6464
env:
6565
SLACK_WEBHOOK: ${{ secrets.SLACK_WEBHOOK }}
66+
SLACK_MESSAGE: ${{ github.repository }}가 ${{ env.NAMESPACE }} 환경에 배포되었습니다 🚀

package-lock.json

Lines changed: 7 additions & 7 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "api-gateway",
3-
"version": "0.9.0",
3+
"version": "1.0.0",
44
"description": "",
55
"author": "",
66
"private": true,
@@ -50,13 +50,13 @@
5050
"eslint-config-prettier": "^8.1.0",
5151
"eslint-plugin-prettier": "^3.3.1",
5252
"jest": "^26.6.3",
53-
"prettier": "^2.5.0",
53+
"prettier": "^2.5.1",
5454
"supertest": "^6.1.3",
5555
"ts-jest": "^26.5.4",
5656
"ts-loader": "^8.0.18",
5757
"ts-node": "^9.1.1",
5858
"tsconfig-paths": "^3.12.0",
59-
"typescript": "^4.4.4"
59+
"typescript": "^4.5.3"
6060
},
6161
"jest": {
6262
"moduleFileExtensions": [

src/app.controller.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -25,8 +25,8 @@ export class AppController {
2525
return this.appService.getVersion();
2626
}
2727

28-
@Get("env")
29-
getEnv(): NodeJS.ProcessEnv {
30-
return this.appService.getEnv();
31-
}
28+
// @Get("env")
29+
// getEnv(): NodeJS.ProcessEnv {
30+
// return this.appService.getEnv();
31+
// }
3232
}

0 commit comments

Comments
 (0)