Skip to content

Commit 7f799b3

Browse files
authored
Merge pull request #16 from bellisk/feat/add-contact-point-to-delete-email
feat: add object_id to dict so that we can retrieve information about…
2 parents 215db82 + 3df220a commit 7f799b3

File tree

3 files changed

+9
-4
lines changed

3 files changed

+9
-4
lines changed

ckanext/subscribe/notification.py

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -380,7 +380,8 @@ def send_emails(notifications_by_email, deletions_by_email):
380380
code, email, notifications, "notification"
381381
)
382382
for email, notifications in deletions_by_email.items():
383-
code = email_auth.create_code(email)
384-
notification_email.send_notification_email(
385-
code, email, notifications, "deletion"
386-
)
383+
for notification in notifications:
384+
code = email_auth.create_code(email)
385+
notification_email.send_notification_email(
386+
code, email, [notification], "deletion"
387+
)

ckanext/subscribe/notification_email.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -56,6 +56,7 @@ def get_notification_email_vars(code, email, notifications):
5656
timestamp=p.toolkit.h.date_str_to_datetime(activity["timestamp"]),
5757
dataset_link=dataset_link_from_activity(activity),
5858
dataset_href=dataset_href_from_activity(activity),
59+
dataset_id=activity["object_id"],
5960
)
6061
)
6162
# get the package/group's name & title

ckanext/subscribe/tests/test_notification_email.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -144,6 +144,7 @@ def test_basic(self):
144144
"activities": [
145145
{
146146
"activity_type": u"new dataset",
147+
"dataset_id": dataset["id"],
147148
"dataset_href": "http://test.ckan.net/dataset/{}".format(
148149
dataset["name"]
149150
),
@@ -187,6 +188,7 @@ def test_group(self):
187188
"activities": [
188189
{
189190
"activity_type": u"new group",
191+
"dataset_id": group["id"],
190192
"dataset_href": u"",
191193
"dataset_link": u"",
192194
"timestamp": activity.timestamp,
@@ -224,6 +226,7 @@ def test_org(self):
224226
"activities": [
225227
{
226228
"activity_type": u"new organization",
229+
"dataset_id": org["id"],
227230
"dataset_href": u"",
228231
"dataset_link": u"",
229232
"timestamp": activity.timestamp,

0 commit comments

Comments
 (0)