Open
Conversation
Owner
|
Hey @balazsnemeth, this looks good to me, sorry I introduced the conflict. Can you add some test cases for these changes? What do you think about making I think it would be good to call Can you also revert the changes to the distribution file? I will generate that when I do the release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When i created a step using
createStep, it's going to automatically create the popup as well and insert it to the DOM. However I had no service to properly destroy/remove thisstep(returned bycreateStep), so I created a service.@benmarch Let me know your thoughts if I need to structure my code on a different way or if something is missing. Thanks, and thanks for this library!