Skip to content

Conversation

CodeDead
Copy link

@CodeDead CodeDead commented May 4, 2025

Partially fixes #299
At least it makes it so that you can compile again.

@xzel23
Copy link
Collaborator

xzel23 commented May 6, 2025

Thank you, I'll test it maybe on the weekend before integrating and spinning a release.

1 similar comment
@xzel23
Copy link
Collaborator

xzel23 commented May 6, 2025

Thank you, I'll test it maybe on the weekend before integrating and spinning a release.

@CodeDead
Copy link
Author

Do you need an extra pair of hands with the maintenance of this project? Happy to help. Just let me know if need be.

@xzel23
Copy link
Collaborator

xzel23 commented May 12, 2025

Hi @CodeDead, thank you for the suggestion! The reason I have not yet merged the PR yet is that we first need a test case for this. You could indeed help. I'll attach a patch where I started working on a test case (without your changes applied). That should work with a pre-JEP 493 JDK. But it fails for whatever reason I did not yet find the time to investigate. After fixing that, the next steps are:

  • add toolchain to the helofx-jep493 test build file, and use the foojay toolchain resolver to automatically install the required temurin JDK 24 toolchain for the build. This should break then the build.
  • When the breakage is confirmed, add your changes. If now the build passes, this can be merged.

If you are willing to follow these steps to update your PR, this would be a great help as I am currently really busy with multiple projects.

@CodeDead
Copy link
Author

Would you like a separate pull request for this test?

@xzel23
Copy link
Collaborator

xzel23 commented May 13, 2025

It doesn't matter. You can put it into a single PR. Just use separate commits.

@CodeDead
Copy link
Author

Sorry, could not get back to you sooner. Have been dealing with a severe covid case and am still healing. Will try to do this when I am able.

@xzel23
Copy link
Collaborator

xzel23 commented May 27, 2025

Thanks for the update, and get well soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

JEP 493 / Temurin JDK 24 breaks plugin

2 participants