style: enforce curly brace style for all control statements across the codebase (#2176)

Author: yvalentin

.eslintrc.json

@@ -25,7 +25,11 @@
       "files": ["*.ts", "*.tsx", "*.mts"],
       "extends": ["plugin:@nx/typescript"],
       "rules": {
-        "@typescript-eslint/no-unused-vars": "off"
+        "@typescript-eslint/no-unused-vars": "off",
+        "curly": [
+          "error",
+          "all"
+        ]
       }
     },
     {
@@ -55,6 +59,10 @@
         "leadingUnderscore": "forbid",
         "trailingUnderscore": "forbid"
       }
+    ],
+    "curly": [
+      "error",
+      "all"
     ]
   }
 }

apps/nuxt/src/components/program/detail/ProgramDetail.vue

@@ -122,7 +122,9 @@ if (currentProgram.value) {
 }
 
 const scrollToRef = (targetRef: HTMLElement | null | undefined) => {
-  if (!targetRef) return
+  if (!targetRef) {
+    return
+  }
   if (targetRef) {
     Scroll.toWithEligibilityBarOffset(targetRef)
   }

apps/nuxt/src/components/project/details/ProjectSideNav.vue

@@ -41,7 +41,9 @@ const scrollTo = (id: string) => {
 }
 
 const hasTestimony = computed(() => {
-  if (!props.project) return false
+  if (!props.project) {
+    return false
+  }
   return testimonies.some((testimony) => testimony.projects?.includes(props.project!.id))
 })
 

apps/nuxt/src/components/project/details/ProjectTestimonies.vue

@@ -29,12 +29,16 @@ const props = defineProps<{
 }>()
 
 const testimoniesToDisplay = computed(() => {
-  if (!props.project) return []
+  if (!props.project) {
+    return []
+  }
   return testimonies.filter((testimony) => testimony.projects?.includes(props.project!.id))
 })
 
 const hasTestimony = computed(() => {
-  if (!props.project) return false
+  if (!props.project) {
+    return false
+  }
   return testimonies.some((testimony) => testimony.projects?.includes(props.project!.id))
 })
 </script>

apps/nuxt/src/pages/TeeBudgetPage.vue

@@ -192,10 +192,14 @@ const formatCurrency = (value: number): string => {
 }
 
 const drawBudgetChart = async () => {
-  if (!budgetChartCanvas.value) return
+  if (!budgetChartCanvas.value) {
+    return
+  }
 
   const chartContext = budgetChartCanvas.value.getContext('2d')
-  if (!chartContext) return
+  if (!chartContext) {
+    return
+  }
 
   // Import Chart.js de manière asynchrone
   const { default: Chart } = await import('chart.js/auto')

apps/nuxt/src/tools/analytic/useExternalLinkTracker.ts

@@ -8,7 +8,9 @@ export function useExternalLinkTracker(type: 'program' | 'project') {
   const trackExternalLinks = (event: Event) => {
     if (import.meta.client) {
       const trackedContainer = document.getElementById('externalLinksTracking')
-      if (!trackedContainer) return
+      if (!trackedContainer) {
+        return
+      }
 
       const target = event.target as HTMLElement
       const link = target.closest('a') as HTMLAnchorElement | null

apps/nuxt/src/tools/companyData/companyData.ts

@@ -111,7 +111,9 @@ export class CompanyData {
   }
 
   static hasSiret() {
-    if (!this.company) return false
+    if (!this.company) {
+      return false
+    }
 
     return !!(this.company as EstablishmentFront)?.siret
   }

libs/backend-ddd/src/common/domain/error/errors.ts

@@ -12,7 +12,9 @@ import ServiceNotFoundError from '../api/serviceNotFoundError'
  * @arg value - expected to be an error, e.g. retrieved with the `catch` keyword.
  */
 export function ensureError(value: unknown): Error {
-  if (value instanceof Error) return value
+  if (value instanceof Error) {
+    return value
+  }
 
   let stringified = '[Unable to stringify the thrown value]'
   try {

libs/backend-ddd/src/opportunity/infrastructure/api/brevo/brevoDeal.ts

@@ -31,8 +31,9 @@ const addBrevoDeal: OpportunityRepository['create'] = async (
 
   if (!dealId.isErr) {
     const maybeError = await associateBrevoDealToContact(dealId.value, domainOpportunity.contactId)
-    if (maybeError.isJust)
+    if (maybeError.isJust) {
       return Result.err(new Error('Something went wrong while attaching contact to opportunity', { cause: maybeError.value }))
+    }
   }
 
   return dealId

libs/data/src/program/dataPipeline.ts

@@ -27,7 +27,9 @@ export const readPrograms = (log = false): ProgramType[] => {
   const __dirname = path.dirname(fileURLToPath(import.meta.url))
   const dataDirPath: string = path.join(__dirname, PROGRAMS_FOLDER_PATH)
 
-  if (log) console.log('📂 Reading data at', dataDirPath, '\n')
+  if (log) {
+    console.log('📂 Reading data at', dataDirPath, '\n')
+  }
 
   const filenames: string[] = fs.readdirSync(dataDirPath)
 
@@ -52,11 +54,15 @@ export const prependInterface = (programs: ProgramType[], log = false): ProgramT
   const __dirname = path.dirname(fileURLToPath(import.meta.url))
   const fullPath: string = path.join(__dirname, INTERFACE_PATH)
 
-  if (log) console.log('🗎 reading constants at', fullPath)
+  if (log) {
+    console.log('🗎 reading constants at', fullPath)
+  }
   const file: string = fs.readFileSync(fullPath, 'utf8')
   const constants = yaml.load(file) as Record<string, unknown>
 
-  if (log) console.log('➕ prepending publicodes with common constants')
+  if (log) {
+    console.log('➕ prepending publicodes with common constants')
+  }
 
   return programs.map((p) => {
     p.publicodes = { ...constants, ...p.publicodes }