-
Notifications
You must be signed in to change notification settings - Fork 12
refactor: implement new CTA card component and fix UI #2088
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR refactors the CTA card system by creating two distinct components: TeeCtaCard
for internal call-to-action cards and TeeIframeCard
for iframe-embedded cards. The refactoring removes generic functionality from the original TeeCtaCard
to create more focused, purpose-specific components.
- Simplified
TeeCtaCard
to focus on internal CTAs with required onClick handlers and descriptions - Created new
TeeIframeCard
component for iframe contexts with external link functionality - Moved shared card styling to global CSS and updated cursor behavior
Reviewed Changes
Copilot reviewed 7 out of 10 changed files in this pull request and generated 2 comments.
Show a summary per file
File | Description |
---|---|
apps/nuxt/src/pages/questions-frequentes/index.vue | Updates TeeCtaCard props and layout structure |
apps/nuxt/src/pages/iframe/projet/[projectSlug].vue | Switches from TeeCtaCard to TeeIframeCard |
apps/nuxt/src/pages/iframe/index.vue | Switches from TeeCtaCard to TeeIframeCard with prop updates |
apps/nuxt/src/components/element/card/TeeIframeCard.vue | New component for iframe-embedded cards with external links |
apps/nuxt/src/components/element/card/TeeCtaCard.vue | Simplified component focused on internal CTAs |
apps/nuxt/src/assets/scss/card.scss | Adds fr-card--cta styles moved from component |
apps/nuxt/src/assets/custom.css | Removes global card hover cursor styling |
Comments suppressed due to low confidence (1)
apps/nuxt/src/components/element/card/TeeIframeCard.vue:91
- The variable name 'imageResizerChild' is misleading as it imports iframe resizer functionality, not image resizing. Consider renaming to 'iframeResizerChild' for clarity.
const imageResizerChild = () => import('@iframe-resizer/child')
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool refacto :)
No description provided.