Skip to content

fix: enhance URL parsing logic in isLocalLink method (canParse) #2121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 1, 2025
Merged

fix: enhance URL parsing logic in isLocalLink method (canParse) #2121

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c3378ba
fix: enhance URL parsing logic in isLocalLink method
yvalentin Jul 30, 2025
6001f09
fix: refactor URL parsing method for improved error handling
yvalentin Jul 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 22 additions & 2 deletions apps/nuxt/src/tools/marked.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,9 +32,14 @@ export class Marked {
}

public static isLocalLink(token: Tokens.Link): boolean {
if (URL.canParse(token.href)) {
if (!token.href) {
return false
}

const url = this.getUrl(token)

if (url) {
const config = useRuntimeConfig()
const url = new URL(token.href)

return (
[config.public.siteUrl, 'https://preprod.mission-transition-ecologique.incubateur.net', 'http://localhost:4242'].includes(
Expand All @@ -45,4 +50,19 @@ export class Marked {

return token.href.startsWith('/')
}

private static getUrl(token: Tokens.Link) {
let url: URL | undefined
if ('canParse' in URL && URL.canParse(token.href)) {
url = new URL(token.href)
} else {
try {
url = new URL(token.href)
} catch (e) {
url = undefined
}
}

return url
}
}
Loading