Feat: meta baserow #2130
Merged
Feat: meta baserow #2130
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d update SEO metadata usage
2 tasks
ttdm
approved these changes
Aug 15, 2025
There was a problem hiding this comment.
Ok pour cette PR.
C'est un début propre pour le ticket sur les balises meta !
Si je comprend bien, c'était pour toi l'occasion de jeter un coup d'oeil sur le package data et tu as fais quelques corrections/améliorations. Merci pour ça :)
J'ai juste mis une question, sur le fichier AbstractBaserow.
RAS pour le reste, merci pour les améliorations ;)
Comment on lines
29
to
36
| protected async _getData<T>(tableId: number) { | ||
| return await this._axios.get<BaserowData<T>>(`${this._baseUrl}/database/rows/table/${tableId}/?user_field_names=true`) | ||
| } | ||
|
|
||
| protected async _getDatum<T>(tableId: number, rowId: number) { | ||
| return await this._axios.get<T>(`${this._baseUrl}/database/rows/table/${tableId}/${rowId}/?user_field_names=true`) | ||
| } | ||
|
|
There was a problem hiding this comment.
Comment : je dois dire que je ne vois pas trop l'intéret de sortir ce code. Tu peux m'expliquer ?
There was a problem hiding this comment.
Juste pour simplifier la lecture
|
# Conflicts: # libs/data/src/common/baserow/abstractBaserow.ts
- Replaced static titles and descriptions with SEO-specific properties (`seoTitle`, `seoDescription`) across multiple pages. - Updated Baserow URL construction by removing redundant `_axiosHeader` and `axios` references, leveraging `_axios` instance instead. - Enhanced type safety by replacing `any` with `unknown` in method parameters.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.