Skip to content

Commit 301f618

Browse files
authored
remove bevy_log as a dev-dependency from bevy_asset (#18619)
# Objective - the bevy workspace fails to publish ``` Packaging bevy_asset v0.16.0-dev (/home/runner/work/bevy-releasability/bevy-releasability/crates/bevy_asset) Updating crates.io index Updating `kellnr` index error: failed to prepare local package for uploading Caused by: no matching package named `bevy_log` found location searched: `kellnr` index required by package `bevy_asset v0.16.0-dev (/home/runner/work/bevy-releasability/bevy-releasability/crates/bevy_asset)` ``` - https://github.com/TheBevyFlock/bevy-releasability/actions/runs/14153238476/job/39649160443 ## Solution - Remove bevy_log dev-dependency from bevy_asset - Not sure of why this is a problem, but the dev-dependency is not really needed so... 🤷
1 parent 35cfef7 commit 301f618

File tree

2 files changed

+3
-20
lines changed

2 files changed

+3
-20
lines changed

crates/bevy_asset/Cargo.toml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -79,9 +79,6 @@ bevy_reflect = { path = "../bevy_reflect", version = "0.16.0-dev", default-featu
7979
[target.'cfg(not(target_arch = "wasm32"))'.dependencies]
8080
notify-debouncer-full = { version = "0.5.0", optional = true }
8181

82-
[dev-dependencies]
83-
bevy_log = { path = "../bevy_log", version = "0.16.0-dev" }
84-
8582
[lints]
8683
workspace = true
8784

crates/bevy_asset/src/lib.rs

Lines changed: 3 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -686,7 +686,6 @@ mod tests {
686686
prelude::*,
687687
schedule::{LogLevel, ScheduleBuildSettings},
688688
};
689-
use bevy_log::LogPlugin;
690689
use bevy_platform_support::collections::HashMap;
691690
use bevy_reflect::TypePath;
692691
use core::time::Duration;
@@ -855,11 +854,7 @@ mod tests {
855854
AssetSourceId::Default,
856855
AssetSource::build().with_reader(move || Box::new(gated_memory_reader.clone())),
857856
)
858-
.add_plugins((
859-
TaskPoolPlugin::default(),
860-
LogPlugin::default(),
861-
AssetPlugin::default(),
862-
));
857+
.add_plugins((TaskPoolPlugin::default(), AssetPlugin::default()));
863858
(app, gate_opener)
864859
}
865860

@@ -1757,11 +1752,7 @@ mod tests {
17571752
"unstable",
17581753
AssetSource::build().with_reader(move || Box::new(unstable_reader.clone())),
17591754
)
1760-
.add_plugins((
1761-
TaskPoolPlugin::default(),
1762-
LogPlugin::default(),
1763-
AssetPlugin::default(),
1764-
))
1755+
.add_plugins((TaskPoolPlugin::default(), AssetPlugin::default()))
17651756
.init_asset::<CoolText>()
17661757
.register_asset_loader(CoolTextLoader)
17671758
.init_resource::<ErrorTracker>()
@@ -1832,11 +1823,7 @@ mod tests {
18321823
AssetSource::build()
18331824
.with_reader(move || Box::new(MemoryAssetReader { root: dir.clone() })),
18341825
)
1835-
.add_plugins((
1836-
TaskPoolPlugin::default(),
1837-
LogPlugin::default(),
1838-
AssetPlugin::default(),
1839-
));
1826+
.add_plugins((TaskPoolPlugin::default(), AssetPlugin::default()));
18401827

18411828
app.init_asset::<CoolText>()
18421829
.init_asset::<SubText>()
@@ -1941,7 +1928,6 @@ mod tests {
19411928
)
19421929
.add_plugins((
19431930
TaskPoolPlugin::default(),
1944-
LogPlugin::default(),
19451931
AssetPlugin {
19461932
unapproved_path_mode: mode,
19471933
..Default::default()

0 commit comments

Comments
 (0)