Clippy

Author: cart

benches/benches/bevy_ecs/observers/propagation.rs

@@ -68,7 +68,7 @@ struct TestEvent<const N: usize> {
 }
 
 fn send_events<const N: usize, const N_EVENTS: usize>(world: &mut World, leaves: &[Entity]) {
-    let target = *leaves.iter().choose(&mut rand::rng()).unwrap();
+    let entity = *leaves.iter().choose(&mut rand::rng()).unwrap();
 
     (0..N_EVENTS).for_each(|_| {
         world.trigger(TestEvent::<N> { entity });

benches/benches/bevy_ecs/observers/simple.rs

@@ -3,7 +3,7 @@ use core::hint::black_box;
 use bevy_ecs::{
     entity::Entity,
     event::{EntityEvent, Event},
-    observer::{EventTargets, On},
+    observer::On,
     world::World,
 };
 
@@ -45,7 +45,7 @@ pub fn observe_simple(criterion: &mut Criterion) {
         }
         entities.shuffle(&mut deterministic_rand());
         bencher.iter(|| {
-            for entity in entities {
+            for entity in entities.iter().copied() {
                 world.trigger(SimpleEntityEvent { entity });
             }
         });

crates/bevy_ecs/macros/src/component.rs

@@ -86,7 +86,7 @@ pub fn derive_entity_event(input: TokenStream) -> TokenStream {
                 processed_attrs.push(AUTO_PROPAGATE);
                 Ok(())
             }
-            #[allow(deprecated)]
+            #[expect(deprecated, reason = "we want to continue supporting this for a release")]
             Some(ident) if ident == TRAVERSAL => {
                 Err(meta.error(
                     "`traversal` has been renamed to `propagate`, use that instead. If you were writing `traversal = &'static ChildOf`, you can now just write `propagate`, which defaults to the `ChildOf` traversal."

crates/bevy_ecs/src/event/mod.rs

@@ -191,7 +191,7 @@ pub trait Event: Send + Sync + Sized + 'static {
 /// #[derive(Component)]
 /// #[relationship(relationship_target = ClickableBy)]
 /// struct Clickable(Entity);
-
+///
 /// #[derive(Component)]
 /// #[relationship_target(relationship = Clickable)]
 /// struct ClickableBy(Vec<Entity>);
@@ -229,7 +229,7 @@ pub trait Event: Send + Sync + Sized + 'static {
 ///     entity: Entity,
 /// }
 /// ```
-
+///
 /// You can also _stop_ propagation like this:
 /// ```
 /// # use bevy_ecs::prelude::*;

crates/bevy_ecs/src/event/trigger.rs

@@ -78,7 +78,7 @@ impl GlobalTrigger {
 
 /// An [`EntityEvent`] [`Trigger`] that does two things:
 /// - Runs all "global" [`Observer`] (ex: registered via [`World::add_observer`](crate::world::World::add_observer))
-/// that matches the given [`Event`]. This is the same behavior as [`GlobalTrigger`].
+///   that matches the given [`Event`]. This is the same behavior as [`GlobalTrigger`].
 /// - Runs every "entity scoped" [`Observer`] that watches the given [`EntityEvent::event_target`] entity.
 ///
 /// The [`EntityEvent`] derive defaults to using this [`Trigger`], and it is usable for any [`EntityEvent`] type.

crates/bevy_ecs/src/observer/distributed_storage.rs

@@ -134,9 +134,9 @@ use crate::prelude::ReflectComponent;
 /// There are some built-in specialized [`Event`] types with custom [`Trigger`] logic:
 ///
 /// - [`EntityEvent`] / [`EntityTrigger`](crate::event::EntityTrigger): An [`Event`] that targets a _specific_ entity. This also has opt-in support for
-///     "event bubbling" behavior. See [`EntityEvent`] for details.
+///   "event bubbling" behavior. See [`EntityEvent`] for details.
 /// - [`EntityComponentsTrigger`](crate::event::EntityComponentsTrigger): An [`Event`] that targets an entity _and_ one or more components on that entity.
-///     This is used for [component lifecycle events](crate::lifecycle).
+///   This is used for [component lifecycle events](crate::lifecycle).
 ///
 /// You can also define your own!
 ///
@@ -203,7 +203,6 @@ use crate::prelude::ReflectComponent;
 ///
 /// [`SystemParam`]: crate::system::SystemParam
 /// [`Trigger`]: crate::event::Trigger
-
 pub struct Observer {
     hook_on_add: ComponentHook,
     pub(crate) error_handler: Option<ErrorHandler>,

crates/bevy_ecs/src/observer/mod.rs

@@ -283,12 +283,6 @@ mod tests {
         counter: usize,
     }
 
-    #[derive(EntityEvent)]
-    struct EntityEventWithData {
-        entity: Entity,
-        counter: usize,
-    }
-
     #[derive(Resource, Default)]
     struct Order(Vec<&'static str>);
 

crates/bevy_ecs/src/observer/system_param.rs

@@ -164,7 +164,7 @@ impl<'w, E: EntityEvent + for<'t> Event<Trigger<'t> = EntityComponentsTrigger<'t
 {
     /// A list of all components that were triggered for this [`EntityEvent`].
     pub fn triggered_components(&self) -> &[ComponentId] {
-        &self.trigger.0
+        self.trigger.0
     }
 }
 

crates/bevy_render/src/sync_world.rs

@@ -503,7 +503,6 @@ mod tests {
     use bevy_ecs::{
         component::Component,
         entity::Entity,
-        event::EntityEvent,
         lifecycle::{Add, Remove},
         observer::On,
         query::With,